libmockturtle.c:trtl_msg_sync: do not add filter (was never removed).

a677cd01 · Tristan Gingold · 2d328195 · a677cd01
Commit a677cd01 authored Sep 04, 2018 by Tristan Gingold
Hide whitespace changes
Inline Side-by-side

Showing with 8 additions and 1 deletion

libmockturtle.c software/lib/libmockturtle.c +8 -1

No files found.
--- a/software/lib/libmockturtle.c
+++ b/software/lib/libmockturtle.c
@@ -1062,21 +1062,28 @@ int trtl_msg_sync(struct trtl_dev *trtl,
 {
 	struct trtl_desc *wdesc = (struct trtl_desc *)trtl;
 	struct polltrtl p;
+#if 0
 	struct trtl_msg_filter f_sync = {
 		.flags = TRTL_MSG_FILTER_FLAG_HEADER,
 		.operation = TRTL_MSG_FILTER_AND,
 		.word_offset = 1, /* ATTENTION: sync_id in the message header */
 		.mask = 0xFFFF0000,
 	};
+#endif
 	int ret;

 	msg_s->hdr.flags |= TRTL_HMQ_HEADER_FLAG_SYNC;
-	f_sync.value = (msg_s->hdr.sync_id << 16);

+#if 0
+        /* FIXME: commented out as the filter is never removed.
+           The filter shouldn't be needed as the synchronous messages are
+           always sent sequentially - if there is only one process.  */
+	f_sync.value = (msg_s->hdr.sync_id << 16);
 	ret = trtl_hmq_filter_add(wdesc->trtl_sync, idx_cpu, idx_hmq,
 				  &f_sync);
 	if (ret < 0)
 		return -1;
+#endif

 	/* send message */
 	ret = trtl_msg_async_send(wdesc->trtl_sync, idx_cpu, idx_hmq, msg_s, 1);