scm: fix log converting error in Ruby 1.9 and add more tests.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@5370 e93f8b46-1217-0410-a6f0-8f06a7374b81

scm: fix log converting error in Ruby 1.9 and add more tests.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@5370 e93f8b46-1217-0410-a6f0-8f06a7374b81
55111556 · Toshi MARUYAMA · Eric Davis · 60b34ea2 · 55111556 · 55111556
Commit 55111556 authored Apr 09, 2011 by Toshi MARUYAMA Committed by Eric Davis Jun 03, 2011
Hide whitespace changes
Inline Side-by-side

Showing with 26 additions and 1 deletion

changeset.rb app/models/changeset.rb +2 -1

changeset_test.rb test/unit/changeset_test.rb +24 -0

No files found.
--- a/app/models/changeset.rb
+++ b/app/models/changeset.rb
@@ -250,7 +250,8 @@ class Changeset < ActiveRecord::Base
      enc = encoding.blank? ? "UTF-8" : encoding
      if enc != "UTF-8"
        str.force_encoding(enc)
-        str = str.encode("UTF-8")
+        str = str.encode("UTF-8", :invalid => :replace,
+              :undef => :replace, :replace => '?')
      end
      if ! str.valid_encoding?
        str = str.encode("US-ASCII", :invalid => :replace,

--- a/test/unit/changeset_test.rb
+++ b/test/unit/changeset_test.rb
@@ -255,6 +255,30 @@ class ChangesetTest < ActiveSupport::TestCase
      end
  end

+  def test_invalid_utf8_sequences_in_comments_should_be_stripped_ja_jis
+      proj = Project.find(3)
+      str = "test\xb5\xfetest\xb5\xfe"
+      if str.respond_to?(:force_encoding)
+        str.force_encoding('ASCII-8BIT')
+      end
+      r = Repository::Bazaar.create!(
+            :project => proj,
+            :url => '/tmp/test/bazaar',
+            :log_encoding => 'ISO-2022-JP' )
+      assert r
+      c = Changeset.new(:repository   => r,
+                        :committed_on => Time.now,
+                        :revision     => '123',
+                        :scmid        => '12345',
+                        :comments     => str)
+      assert( c.save )
+      if str.respond_to?(:force_encoding)
+        assert_equal "test??test??", c.comments
+      else
+        assert_equal "testtest", c.comments
+      end
+  end
+
  def test_comments_should_be_converted_all_latin1_to_utf8
      s1 = "\xC2\x80"
      s2 = "\xc3\x82\xc2\x80"