Force string comparison for login search to be case sensitive on MySQL. #2473

Contributed by Holger Just. git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3813 e93f8b46-1217-0410-a6f0-8f06a7374b81

Force string comparison for login search to be case sensitive on MySQL. #2473
Contributed by Holger Just. git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3813 e93f8b46-1217-0410-a6f0-8f06a7374b81
672852ba · Eric Davis · 6eea3300 · 672852ba
Commit 672852ba authored Jun 24, 2010 by Eric Davis
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 2 deletions

user.rb app/models/user.rb +5 -2

No files found.
--- a/app/models/user.rb
+++ b/app/models/user.rb
@@ -225,10 +225,13 @@ class User < Principal
  # Find a user account by matching the exact login and then a case-insensitive
  # version.  Exact matches will be given priority.
  def self.find_by_login(login)
+    # force string comparison to be case sensitive on MySQL
+    type_cast = (ActiveRecord::Base.connection.adapter_name == 'MySQL') ? 'BINARY' : ''
+    
    # First look for an exact match
-    user = first(:conditions => {:login => login})
+    user = first(:conditions => ["#{type_cast} login = ?", login])
    # Fail over to case-insensitive if none was found
-    user ||= first(:conditions => ["LOWER(login) = ?", login.to_s.downcase])
+    user ||= first(:conditions => ["#{type_cast} LOWER(login) = ?", login.to_s.downcase])
  end

  def self.find_by_rss_key(key)