Show projects depending on their visibility in user's profile. #6100

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3935 e93f8b46-1217-0410-a6f0-8f06a7374b81

Show projects depending on their visibility in user's profile. #6100
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3935 e93f8b46-1217-0410-a6f0-8f06a7374b81
e43f9fc2 · Jean-Baptiste Barth · 0cfa757d · e43f9fc2 · e43f9fc2
Commit e43f9fc2 authored Aug 10, 2010 by Jean-Baptiste Barth
Hide whitespace changes
Inline Side-by-side

Showing with 12 additions and 4 deletions

users_controller.rb app/controllers/users_controller.rb +2 -4

users_controller_test.rb test/functional/users_controller_test.rb +10 -0

No files found.
--- a/app/controllers/users_controller.rb
+++ b/app/controllers/users_controller.rb
@@ -53,10 +53,8 @@ class UsersController < ApplicationController
    @user = User.find(params[:id])
    @custom_values = @user.custom_values
-    # show only public projects and private projects that the logged in user is also a member of
+    # show projects based on current user visibility
-    @memberships = @user.memberships.select do |membership|
+    @memberships = @user.memberships.all(:conditions => Project.visible_by(User.current))
-      membership.project.is_public? || (User.current.member_of?(membership.project))
-    end
    events = Redmine::Activity::Fetcher.new(User.current, :author => @user).events(nil, nil, :limit => 10)
    @events_by_day = events.group_by(&:event_date)

--- a/test/functional/users_controller_test.rb
+++ b/test/functional/users_controller_test.rb
@@ -96,6 +96,16 @@ class UsersControllerTest < ActionController::TestCase
    assert_response 200
    assert_not_nil assigns(:user)
  end
+  def test_show_displays_memberships_based_on_project_visibility
+    @request.session[:user_id] = 1
+    get :show, :id => 2
+    assert_response :success
+    memberships = assigns(:memberships)
+    assert_not_nil memberships
+    project_ids = memberships.map(&:project_id)
+    assert project_ids.include?(2) #private project admin can see
+  end
  def test_edit
    ActionMailer::Base.deliveries.clear