Commits · fe1e3ccd18420752979d817fac4408c780ba1da2 · Projects / OHR Support

03 Mar, 2010 4 commits

Refactor: Decouple failed attachments and the flash messages · fe1e3ccd

Eric Davis authored Mar 03, 2010

Attachment#attach_files will no longer need to return a flash message,
instead it will put unsaved attachments into object#unsaved_attachments
where the calling object can access them.

A utility method #render_attachment_warning_if_needed is included for setting
the standard flash warning.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3528 e93f8b46-1217-0410-a6f0-8f06a7374b81

fe1e3ccd

Added test for when an attachment fails to save. · 44955a51

Eric Davis authored Mar 03, 2010

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3527 e93f8b46-1217-0410-a6f0-8f06a7374b81

44955a51

Fixes destroying attachments if the update fails. (r2875 r3523) · f6d8752e
Eric Davis authored Mar 03, 2010
```
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3526 e93f8b46-1217-0410-a6f0-8f06a7374b81
```
f6d8752e
Allow multiple selected projects in #project_tree_options_for_select · 3c0c0a76
Eric Davis authored Mar 03, 2010
```
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3525 e93f8b46-1217-0410-a6f0-8f06a7374b81
```
3c0c0a76

02 Mar, 2010 3 commits
- Fixed: error while deleting an in-use enumeration (#4970). · b09a483a
  Jean-Philippe Lang authored Mar 02, 2010
```
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3524 e93f8b46-1217-0410-a6f0-8f06a7374b81
```
  b09a483a
- Refactor: Moved ApplicationController#attach_files to the Attachment model · 0fd7e2d6
  Eric Davis authored Mar 02, 2010
```
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3523 e93f8b46-1217-0410-a6f0-8f06a7374b81
```
  0fd7e2d6
- Fixes failing tests from r3521 · 81d617cd
  Eric Davis authored Mar 02, 2010
```
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3522 e93f8b46-1217-0410-a6f0-8f06a7374b81
```
  81d617cd
01 Mar, 2010 3 commits
- Fixes some context menu links broken by r3478. · b52e75aa
  Jean-Philippe Lang authored Mar 01, 2010
```
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3521 e93f8b46-1217-0410-a6f0-8f06a7374b81
```
  b52e75aa
- Verify issues are updated by HTTP PUT only. Regression from r3486. · f5f5a5f6
  Eric Davis authored Mar 01, 2010
```
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3520 e93f8b46-1217-0410-a6f0-8f06a7374b81
```
  f5f5a5f6
- Refactor: Decouple building Issue and TimeEntry objects in #issue_update. · 8699e5bb
  Eric Davis authored Mar 01, 2010
```
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3519 e93f8b46-1217-0410-a6f0-8f06a7374b81
```
  8699e5bb
28 Feb, 2010 14 commits
- Adds a test for not sending email without recipient (#4920). · ae559785
  Jean-Philippe Lang authored Feb 28, 2010
```
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3518 e93f8b46-1217-0410-a6f0-8f06a7374b81
```
  ae559785
- Fixed: Trac importer creates duplicate wiki records (#4743). · 8e57b1f6
  Jean-Philippe Lang authored Feb 28, 2010
```
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3517 e93f8b46-1217-0410-a6f0-8f06a7374b81
```
  8e57b1f6
- Fixes bottom links placement in issue with associated changesets (#4883). · c9197769
  Jean-Philippe Lang authored Feb 28, 2010
```
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3516 e93f8b46-1217-0410-a6f0-8f06a7374b81
```
  c9197769
- Fixed: Plugin generators should display help if no parameter is given (#4609). · da844743
  Jean-Philippe Lang authored Feb 28, 2010
```
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3514 e93f8b46-1217-0410-a6f0-8f06a7374b81
```
  da844743
- Fixed: Git blame/annotate fails on moved files (#3832). · 9a85d4d0
  Jean-Philippe Lang authored Feb 28, 2010
```
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3513 e93f8b46-1217-0410-a6f0-8f06a7374b81
```
  9a85d4d0
- Adds 'Blocked by' (#1755) and 'Duplicated by' relation types to the dropdown… · d6c299f5
  Jean-Philippe Lang authored Feb 28, 2010
```
Adds 'Blocked by' (#1755) and 'Duplicated by' relation types to the dropdown menu for new relations.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3512 e93f8b46-1217-0410-a6f0-8f06a7374b81
```
  d6c299f5
- Fixed: attachments with the same name at the same time overwrite (#3691). · 241f79ac
  Jean-Philippe Lang authored Feb 28, 2010
```
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3511 e93f8b46-1217-0410-a6f0-8f06a7374b81
```
  241f79ac
- Allow project custom fields to be searchable (#4945). · 82310d31
  Jean-Philippe Lang authored Feb 28, 2010
```
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3510 e93f8b46-1217-0410-a6f0-8f06a7374b81
```
  82310d31
- Fixes a test failure due to a default custom field value. · 1ab77ee0
  Jean-Philippe Lang authored Feb 28, 2010
```
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3509 e93f8b46-1217-0410-a6f0-8f06a7374b81
```
  1ab77ee0
- Adds missing fixtures. · 551993d3
  Jean-Philippe Lang authored Feb 28, 2010
```
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3508 e93f8b46-1217-0410-a6f0-8f06a7374b81
```
  551993d3
- Update for 0.9.3 release. · 049f47ea
  Jean-Philippe Lang authored Feb 28, 2010
```
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3506 e93f8b46-1217-0410-a6f0-8f06a7374b81
```
  049f47ea
- Adds attachments upload on wiki edit form (#1223). · c174540a
  Jean-Philippe Lang authored Feb 28, 2010
```
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3500 e93f8b46-1217-0410-a6f0-8f06a7374b81
```
  c174540a
- Fixed: journal details duplicated when an issue is saved twice (#3690). · 02cc0efd
  Jean-Philippe Lang authored Feb 28, 2010
```
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3499 e93f8b46-1217-0410-a6f0-8f06a7374b81
```
  02cc0efd
- Fixed: Wrong link when "http" not included in project "Homepage" link (#4944). · 26e9a0d9
  Jean-Philippe Lang authored Feb 28, 2010
```
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3498 e93f8b46-1217-0410-a6f0-8f06a7374b81
```
  26e9a0d9
26 Feb, 2010 10 commits
- Refactor: Extracted saving logic out of #update and into a utility method · ddec53b9
  Eric Davis authored Feb 26, 2010
```
Now #issue_update can be refactored and push to the Model(s) while keeping
the public interface (#update) clean.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3497 e93f8b46-1217-0410-a6f0-8f06a7374b81
```
  ddec53b9
- Link to the user from the wiki history view. · 11304941
  Jean-Philippe Lang authored Feb 26, 2010
```
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3496 e93f8b46-1217-0410-a6f0-8f06a7374b81
```
  11304941
- Adds a link to the user profile from the administration user edit screen (#4480). · bda2aa47
  Jean-Philippe Lang authored Feb 26, 2010
```
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3495 e93f8b46-1217-0410-a6f0-8f06a7374b81
```
  bda2aa47
- Removes a useless assignment in Trac importer (#4931). · c7c43d38
  Jean-Philippe Lang authored Feb 26, 2010
```
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3494 e93f8b46-1217-0410-a6f0-8f06a7374b81
```
  c7c43d38
- Let administrators see locked user profiles. · bfed36ac
  Jean-Philippe Lang authored Feb 26, 2010
```
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3493 e93f8b46-1217-0410-a6f0-8f06a7374b81
```
  bfed36ac
- Makes AuthSource.authenticate return a hash instead of an array. · d6f9e576
  Jean-Philippe Lang authored Feb 26, 2010
```
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3492 e93f8b46-1217-0410-a6f0-8f06a7374b81
```
  d6f9e576
- Test that AuthSourceLdap#authenticate returns valid User attributes only. · f1d16bc0
  Jean-Philippe Lang authored Feb 26, 2010
```
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3491 e93f8b46-1217-0410-a6f0-8f06a7374b81
```
  f1d16bc0
- Moves the LDAP test server to a fixture. · 899f0661
  Jean-Philippe Lang authored Feb 26, 2010
```
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3490 e93f8b46-1217-0410-a6f0-8f06a7374b81
```
  899f0661
- Adds a sample test LDAP configuration file. · 7ae53845
  Jean-Philippe Lang authored Feb 26, 2010
```
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3489 e93f8b46-1217-0410-a6f0-8f06a7374b81
```
  7ae53845
- User model should not have to clean up LDAP attributes. · aa521c5a
  Jean-Philippe Lang authored Feb 26, 2010
```
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3488 e93f8b46-1217-0410-a6f0-8f06a7374b81
```
  aa521c5a
25 Feb, 2010 4 commits

Refactor: Extracted the duplication from the last commit into a new method · 3de1f2e1
Eric Davis authored Feb 25, 2010
```
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3487 e93f8b46-1217-0410-a6f0-8f06a7374b81
```
3de1f2e1
Refactor: Move the updating of an Issue to the #update method. · c68d853b
Eric Davis authored Feb 25, 2010
```
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3486 e93f8b46-1217-0410-a6f0-8f06a7374b81
```
c68d853b

Fix LDAP on the fly creation. The User object doesn't have a :dn attribute. · 19d4ddf2

Eric Davis authored Feb 25, 2010

Fixes #4918 and adds a test for the behavior.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3485 e93f8b46-1217-0410-a6f0-8f06a7374b81

19d4ddf2

Optimize: Only select the name when getting the module names. · 39c97279

Eric Davis authored Feb 25, 2010

This has speed up TimelogController#details by 100% with larger databases
(demo.redmine went from 4077ms down to 2085ms).

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3484 e93f8b46-1217-0410-a6f0-8f06a7374b81

39c97279

24 Feb, 2010 2 commits
- Fixed: changing user/roles of project member not possible without javascript (#4852) · f7bd0801
  Jean-Philippe Lang authored Feb 24, 2010
```
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3483 e93f8b46-1217-0410-a6f0-8f06a7374b81
```
  f7bd0801
- Fixed: projects are referenced by id in search results. · 46ecc488
  Jean-Philippe Lang authored Feb 24, 2010
```
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3482 e93f8b46-1217-0410-a6f0-8f06a7374b81
```
  46ecc488