bugfix/workaround: unix-socket: disable settings for UDP/pdelay

This won't work, because packets must be sent to two different IP multicast addresses. This is not supported. The code being disabled had the effect of setting the pdelay destination for all frames, even for E2E runs. This fixes E2E UDP operation, leaving P2P broken as it was. Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

bugfix/workaround: unix-socket: disable settings for UDP/pdelay
This won't work, because packets must be sent to two different IP multicast addresses. This is not supported. The code being disabled had the effect of setting the pdelay destination for all frames, even for E2E runs. This fixes E2E UDP operation, leaving P2P broken as it was. Signed-off-by: Alessandro Rubini <rubini@gnudd.com>
29b77da9 · Alessandro Rubini · ca2443b2 · 29b77da9
Commit 29b77da9 authored Sep 06, 2016 by Alessandro Rubini
Show whitespace changes
Inline Side-by-side

Showing with 3 additions and 0 deletions

unix-socket.c time-unix/unix-socket.c +3 -0

No files found.
--- a/time-unix/unix-socket.c
+++ b/time-unix/unix-socket.c
@@ -431,6 +431,8 @@ static int unix_open_ch_udp(struct pp_instance *ppi, char *ifname, int chtype)
 		       &imr, sizeof(struct ip_mreq)) < 0)
 		goto err_out;

+#if 0 /* FIXME: UDP pdelay is not working due to address inflation */
+
 	/* Init Peer multicast IP address */
 	memcpy(addr_str, PP_PDELAY_DOMAIN_ADDRESS, INET_ADDRSTRLEN);

@@ -446,6 +448,7 @@ static int unix_open_ch_udp(struct pp_instance *ppi, char *ifname, int chtype)
 	if (setsockopt(sock, IPPROTO_IP, IP_ADD_MEMBERSHIP,
 		       &imr, sizeof(struct ip_mreq)) < 0)
 		goto err_out;
+#endif

 	/* End of General multicast Ip address init */