trivial: mark static functions as static

All functions in msg.c that are used locally are now static. There is one that is never used at all (msg_unpack_delay_req) but I fear I need more auditing before removing it. It may be something we need to do, I'm not sure. Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

trivial: mark static functions as static
All functions in msg.c that are used locally are now static. There is one that is never used at all (msg_unpack_delay_req) but I fear I need more auditing before removing it. It may be something we need to do, I'm not sure. Signed-off-by: Alessandro Rubini <rubini@gnudd.com>
495d332a · Alessandro Rubini · 689ce9cb · 495d332a · 495d332a
Commit 495d332a authored Nov 13, 2014 by Alessandro Rubini
Show whitespace changes
Inline Side-by-side

Showing with 5 additions and 13 deletions

ppsi.h include/ppsi/ppsi.h +0 -8

msg.c proto-standard/msg.c +5 -5

No files found.
--- a/include/ppsi/ppsi.h
+++ b/include/ppsi/ppsi.h
@@ -339,18 +339,10 @@ extern int bmc(struct pp_instance *ppi);
 extern void msg_pack_header(struct pp_instance *ppi, void *buf);
 extern int __attribute__((warn_unused_result))
 	msg_unpack_header(struct pp_instance *ppi, void *buf, int plen);
-extern void msg_pack_sync(struct pp_instance *ppi, Timestamp *orig_tstamp);
 extern void msg_unpack_sync(void *buf, MsgSync *sync);
-extern int msg_pack_announce(struct pp_instance *ppi);
 extern void msg_unpack_announce(void *buf, MsgAnnounce *ann);
-extern void msg_pack_follow_up(struct pp_instance *ppi,
-			       Timestamp *prec_orig_tstamp);
 extern void msg_unpack_follow_up(void *buf, MsgFollowUp *flwup);
-extern void msg_pack_delay_req(struct pp_instance *ppi,
-			       Timestamp *orig_tstamp);
 extern void msg_unpack_delay_req(void *buf, MsgDelayReq *delay_req);
-extern void msg_pack_delay_resp(struct pp_instance *ppi,
-				MsgHeader *hdr, Timestamp *rcv_tstamp);
 extern void msg_unpack_delay_resp(void *buf, MsgDelayResp *resp);

 /* each of them returns 0 if no error and -1 in case of error in send */

--- a/proto-standard/msg.c
+++ b/proto-standard/msg.c
@@ -84,7 +84,7 @@ void msg_pack_header(struct pp_instance *ppi, void *buf)
 }

 /* Pack Sync message into out buffer of ppi */
-void msg_pack_sync(struct pp_instance *ppi, Timestamp *orig_tstamp)
+static void msg_pack_sync(struct pp_instance *ppi, Timestamp *orig_tstamp)
 {
 	void *buf;

@@ -123,7 +123,7 @@ void msg_unpack_sync(void *buf, MsgSync *sync)
 }

 /* Pack Announce message into out buffer of ppi */
-int msg_pack_announce(struct pp_instance *ppi)
+static int msg_pack_announce(struct pp_instance *ppi)
 {
 	void *buf;

@@ -187,7 +187,7 @@ void msg_unpack_announce(void *buf, MsgAnnounce *ann)
 }

 /* Pack Follow Up message into out buffer of ppi*/
-void msg_pack_follow_up(struct pp_instance *ppi, Timestamp *prec_orig_tstamp)
+static void msg_pack_follow_up(struct pp_instance *ppi, Timestamp *prec_orig_tstamp)
 {
 	void *buf;

@@ -229,7 +229,7 @@ void msg_unpack_follow_up(void *buf, MsgFollowUp *flwup)
 }

 /* pack DelayReq message into out buffer of ppi */
-void msg_pack_delay_req(struct pp_instance *ppi, Timestamp *orig_tstamp)
+static void msg_pack_delay_req(struct pp_instance *ppi, Timestamp *orig_tstamp)
 {
 	void *buf;

@@ -259,7 +259,7 @@ void msg_pack_delay_req(struct pp_instance *ppi, Timestamp *orig_tstamp)
 }

 /* pack DelayResp message into OUT buffer of ppi */
-void msg_pack_delay_resp(struct pp_instance *ppi,
+static void msg_pack_delay_resp(struct pp_instance *ppi,
 			 MsgHeader *hdr, Timestamp *rcv_tstamp)
 {
 	void *buf;