servo: remove wrong and needless average in owd

The "Use the average between current value and previous one" in the "one way delay" calculation was actually a running-average of two samples. This happened before the real (and properly implemented) running average of the value. By removing the first one we better respect the configured width of the filter. As a side effect the default (64 samples) is now effective, while earlier it behaved like a 128-sample running average. It converges faster. Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

servo: remove wrong and needless average in owd
The "Use the average between current value and previous one" in the "one way delay" calculation was actually a running-average of two samples. This happened before the real (and properly implemented) running average of the value. By removing the first one we better respect the configured width of the filter. As a side effect the default (64 samples) is now effective, while earlier it behaved like a 128-sample running average. It converges faster. Signed-off-by: Alessandro Rubini <rubini@gnudd.com>
a6b46a9e · Alessandro Rubini · ac6542d1 · a6b46a9e
Commit a6b46a9e authored Sep 14, 2013 by Alessandro Rubini
Hide whitespace changes
Inline Side-by-side

Showing with 0 additions and 4 deletions

servo.c proto-standard/servo.c +0 -4

No files found.
--- a/proto-standard/servo.c
+++ b/proto-standard/servo.c
@@ -133,10 +133,6 @@ void pp_servo_got_resp(struct pp_instance *ppi)
 		else if (owd_fltr->s_exp > 1 << s)
 			owd_fltr->s_exp = 1 << s;

-		/* Use the average between current value and previous one */
-		owd->nanoseconds = (owd->nanoseconds + owd_fltr->nsec_prev) / 2;
-		owd_fltr->nsec_prev = owd->nanoseconds;
-
 		/* filter 'oneWayDelay' (running average) */
 		owd_fltr->y = (owd_fltr->y * (owd_fltr->s_exp - 1)
 			       + owd->nanoseconds)