Commit only build for arch-unix (and no tools either)
This simplifies a lot the calculations.

  - all times are now living in a single structure
  - all fields are signed and 64-bit long
  - the 2038 bug is over (we still had 32-bit seconds)
  - no overflow in math or unexplained "unsigned" appearing
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

    See Table 13.
    Note that we keep currentUtcOffset as it is and reset currentUtcOffsetValid,
    because  we presently don't know about leap seconds.
    leap59 and leap61 are forced to zero.

See Table 13.

This adds -Wstrict-prototypes -Wmissing-prototypes and takes actions
accordingly.

Some of the solutions are ugly, especially in the bare architectures,
but I prefer to be warned if I take dangerous paths wrt prototypes while
writing further code.

I'm upset by those two not being included in -Wall, as they used to.
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Port configured to PPSI_ROLE_MASTER must do m1() update of data set
only if it is a port of a GM. We need the dataSet comparision to
know this (thus we calculate the compres value) even on the ports
forced to be masters by default

master port on GM should copy DefaultDS.clockQuality (e.g. clockClass)
to ParentDS.grandmaster.clockQuality so that it is send out in Announce
messages. BC should not do that, as it copies clockQuality received
on the slave port into the ParentDS.grandmaster.ClockQuality and sends
out on its master ports this info.

This paves the way to the addition of a third protocol. Besides the
code is slightly smaller (around 50 bytes on all archs).
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Bitfields are bad, so this turns them into flags and constants.
There should be no change at all in behaviour (although the code
is a little smaller).

The next commit does a change for real.
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

given that INTS() is defined as inline it should not affect
the performance even in time-critical cases.

Also, report how may are there in bmc diagnostics
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

This patch adds support for modifying the utc/tai offset. The
"set" time operation, when called with a NULL pointer to the time
structure, will do the operation in its own arch-specific way.
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

This adds support for the utc/tai offset.
Unix, bare and wrs use UTC in system time and TAI in PTP frames.
WR time is TAI as well, and wrpc-sw passes 0 as offset value when
run as master.
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

The 1588 standard talks extensively about "mean path delay"
and the meanPathDelay variable.   Even if the name is not the
best one, we'd better rename the fields and variable.

This is a massive change, but the currenct code has been validated at
the Lemgo plug fest, and I don't expect any need to revert older
patches at this point.  I'm sorry for git-blame users, including myself,
but this change is a step forward.  I should have knonw better when
choosing "one way delay" between the two names of the older code.

Thanks to Aurelio for noting the problem.
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

This rename is for consistency: the filter is called owd_fltr but the
data it acts upon were called a meaningless "mean path delay".
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

This changes all "Name Surname for CERN" to "Copyright CERN, author
Name Surname".  This is trivial and makes no change, with a few
expections:

- all trivial Makefiles that had "for CERN" lines have now no
attributions, as they are trivial anyways.

- a few unrepresented files have not the copyright notice (especially
ptpdump, that I wrote in 2012).

- a few "for CERN" remain in subprojects, where I didn't touch anyrhing
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

The pp_links mechanism, currently based on /etc/ppsi.conf file, shall not
be mandatory, since not all archs will use it. Thus, this patch reduces
at its minimum the dependency on ppi->nlinks. If an arch is not using
the pp_links, it just has to define nlinks=0 in pp_globals struct, and
the engine will work as well, assuming one pp_instance has been
configured in the main.
Signed-off-by: Aurelio Colosimo <aurelio@aureliocolosimo.it>

This major patch implements the core of Best Master Clock Algorithm for
multilink context (e.g. Boundary Clock).
Signed-off-by: Aurelio Colosimo <aurelio@aureliocolosimo.it>

Signed-off-by: Aurelio Colosimo <aurelio@aureliocolosimo.it>

This partially reverts commit 16707d53, since the IEEE spec states that foreign
masters list must be kept updated for each link, then Ebest search among all
links must be performed.
Signed-off-by: Aurelio Colosimo <aurelio@aureliocolosimo.it>

Due to multilink needs, those variables are no more global but can be defined
as a different setting for each port. They will be set in a /etc/ppsi.conf file,
which is not yet handled, but will be soon.
struct pp_runtime_opts will contain only multiport settings.
If the /etc/ppsi.conf file is not found or not handled (like it is at present),
ppsi accepts and properly handles the same cmd line options as in the past.
Signed-off-by: Aurelio Colosimo <aurelio@aureliocolosimo.it>

Signed-off-by: Aurelio Colosimo <aurelio@aureliocolosimo.it>

No functional change at all, just rename and make var name shorter.
Signed-off-by: Aurelio Colosimo <aurelio@aureliocolosimo.it>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

This simplifies the dataset_cmp a little more, and adds some comment.
Nothing changes in the outcome of this commit but I'm unsure about the
code (i.e about the original code).

The specification says to compare *port* identities, but we are
comparing clock identities instead. This is the same in the original
ptpd, so if it is wrong it has always been.

We'll be able to see what happens when checking with several masters,
after porting ppsi to multi-link setup.
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

This replaces
     memcmp(a, b, PP_CLOCK_IDENTITY_LENGTH)
with
     idcmp(a, b)
and makes no other changes.
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

A large number of functions here got hdr and ann, but struct
pp_frgn_master includes such fields, and most callers passed hdr and
ann from the same structure.

So I chose to pass a foreign master instead of the two components, but
I'm still unable to remove the two full structures inside until I
clean up the msg.c mess.   So, at the end, this is not really a step
forward, but it helps such later step.
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Trivially, return what we have, becuase less than zero is less than
zero.  No, the wouldn't pass my exam.
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

When the "if" branch returns, we don't need an "else" branch.  These
students wouldn't pass my exam.
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

You may be bored by these small changes, but I want to show that
I didn't introduce errors. In any case, each such change is reducing
both entropy in the source and binary size in the output.
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

This "type" was the only type represented as an array instead of
being a structure. This leads to inconsistent use: if you memcpy
the other ones you need "&", but not here.

So this commit uses an encompassing structure, to have ClockIdentity
behave like other composite fields.  The commit has no effect at all
on the generated binary files for wrpc but it unexpectedly reduces the
size of the output on the PC. Anyways, the commit is trivial, and all
changes can be easily verified to have no effect.

While this increases entropy, the reasoning is that I want to assign
structures instead of running zillions of memcpy functions, with the
hairy PP_CLOCK_IDENTITY_LENGTH.  So later commits, based on this one,
reduce entropy.
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>