new fmc-bus and fix in destroy(), to match new dev->release

fmc-bus is now fixed WRT the dev->release(). Now devices are correctly released when their use count reaches zero. Thus, we can't release them ourselves. This commit picks the new fmc-bus and adapts th own releae method. Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

new fmc-bus and fix in destroy(), to match new dev->release
fmc-bus is now fixed WRT the dev->release(). Now devices are correctly released when their use count reaches zero. Thus, we can't release them ourselves. This commit picks the new fmc-bus and adapts th own releae method. Signed-off-by: Alessandro Rubini <rubini@gnudd.com>
580113ae · Alessandro Rubini · dcafaf66 · 580113ae
Commit 580113ae authored Apr 29, 2013 by Alessandro Rubini
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 1 deletion

spec-fmc.c kernel/spec-fmc.c +3 -1

No files found.
--- a/kernel/spec-fmc.c
+++ b/kernel/spec-fmc.c
@@ -449,10 +449,12 @@ out_free:

 void spec_fmc_destroy(struct spec_dev *spec)
 {
+	/* undo the things in the reverse order, but pin the device first */
+	get_device(&spec->fmc->dev);
 	spec_gpio_exit(spec->fmc);
 	fmc_device_unregister(spec->fmc);
 	spec_irq_exit(spec->fmc);
 	spec_i2c_exit(spec->fmc);
-	kfree(spec->fmc);
+	put_device(&spec->fmc->dev);
 	spec->fmc = NULL;
 }