Commit d195f1d7 authored by Adam Wujek's avatar Adam Wujek 💬 Committed by Alessandro Rubini

wr_nic: unify not runing the timer on SPEC

Removed if statement for SPEC is never reached due to return
in if(WR_IS_NODE) block.

Remove commit from spec-sw repo:
kernel/wr_nic/endpoint.c: don't run the timer

In the switch we used to have a timer to check for link status, but
in the SPEC card the internal lm32 does that, and access to the phy
is not atomic. Assume the link is always on until we'll get notification
from lm32 to the host.
Signed-off-by: Adam Wujek's avatarAdam Wujek <>
parent f0efd790
......@@ -207,13 +207,9 @@ int wrn_ep_open(struct net_device *dev)
/* Prepare the timer for link-up notifications */
setup_timer(&ep->ep_link_timer, wrn_ep_check_link, timerarg);
if (0) {
/* not on spec */
mod_timer(&ep->ep_link_timer, jiffies + WRN_LINK_POLL_INTERVAL);
} else {
/* Assume it's already on */
/* Not on spec. On spec this part of the function is never reached
* due to return in if(WR_IS_NODE) */
mod_timer(&ep->ep_link_timer, jiffies + WRN_LINK_POLL_INTERVAL);
return 0;
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment