Commit e459ef1b authored by Federico Vaga's avatar Federico Vaga

kernel: info about VIC failure

The error conditions are very rare and when they happen it means
that we have a bug. So, I do not care much about the possibility
of having many prints in an IRQ handler. Something is really wrong
and we must fix it before releasing.
Signed-off-by: Federico Vaga's avatarFederico Vaga <federico.vaga@cern.ch>
parent 481b8821
......@@ -128,12 +128,19 @@ irqreturn_t spec_vic_irq_dispatch(struct spec_dev *spec)
*/
index = vic_readl(vic, VIC_REG_VAR) & 0xff;
if (index >= VIC_MAX_VECTORS)
if (index >= VIC_MAX_VECTORS) {
dev_err(&spec->pdev->dev, "Invalid VIC index %d (max %d)\n",
index, VIC_MAX_VECTORS);
goto fail;
}
vec = &vic->vectors[index];
if (!vec->handler)
if (!vec->handler) {
dev_err(&spec->pdev->dev,
"Handler not found for vector %d\n",
index);
goto fail;
}
rv = vec->handler(vec->saved_id, vec->requestor);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment