kernel: do not use statement-scope variable

When possible, avoid statement-scope variable for a better maintanability of the code. Signed-off-by: Federico Vaga <federico.vaga@cern.ch>

kernel: do not use statement-scope variable
When possible, avoid statement-scope variable for a better maintanability of the code. Signed-off-by: Federico Vaga <federico.vaga@cern.ch>
877b4ecb · Federico Vaga · a9b4d07c · 877b4ecb
Commit 877b4ecb authored Jul 04, 2014 by Federico Vaga
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 3 deletions

svec-vic.c kernel/svec-vic.c +2 -3

No files found.
--- a/kernel/svec-vic.c
+++ b/kernel/svec-vic.c
@@ -202,12 +202,11 @@ void svec_vic_irq_free(struct svec_dev *svec, unsigned long id)
 	int i;

 	for (i = 0; i < VIC_MAX_VECTORS; i++) {
-		uint32_t vec = svec->vic->vectors[i].saved_id;
-		if (vec == id) {
+		if (svec->vic->vectors[i].saved_id == id) {
 			spin_lock(&svec->vic->vec_lock);

 			vic_writel(svec->vic, 1 << i, VIC_REG_IDR);
-			vic_writel(svec->vic, vec, VIC_IVT_RAM_BASE + 4 * i);
+			vic_writel(svec->vic, id, VIC_IVT_RAM_BASE + 4 * i);
 			svec->vic->vectors[i].handler = NULL;

 			spin_unlock(&svec->vic->vec_lock);