dlamprid-vme64x_review.org 1.79 KB
Newer Older
Tristan Gingold's avatar
Tristan Gingold committed
1 2 3
* General notes
- pull dlamprid-vme64x_review for both the core and the SVEC demo (vmecore_test)
  + adjust/merge as you see fit
4
  Done
Tristan Gingold's avatar
Tristan Gingold committed
5
- [Update]/[Delete] top-level README.txt?
6
  Done
Tristan Gingold's avatar
Tristan Gingold committed
7
- [Update] HDL headers
8
  OK.
Tristan Gingold's avatar
Tristan Gingold committed
9
- [Update]/[Delete]/[Move to user manual] header comments with technical explanations?
10
  OK.
Tristan Gingold's avatar
Tristan Gingold committed
11 12
- Good opportunity to rename files, entities and instances. eg:
  + pack or pkg?
13
  _pkg (same name as the design unit name).
Tristan Gingold's avatar
Tristan Gingold committed
14
  + capital or small case file names?
15
  The same case, lower case.
Tristan Gingold's avatar
Tristan Gingold committed
16
  + ...
Tristan Gingold's avatar
Tristan Gingold committed
17
  Done.
Tristan Gingold's avatar
Tristan Gingold committed
18
- does not strictly follow proposed folder structure
19
  See Maciej comment
Tristan Gingold's avatar
Tristan Gingold committed
20 21 22

* VME64x core
- get rid of SVEC_ID, CERN_ID etc from package and default generic values
Tristan Gingold's avatar
Tristan Gingold committed
23
  Done. OK for default generic
Tristan Gingold's avatar
Tristan Gingold committed
24
- what happens if the c_CLOCK_PERIOD is wrong? maybe it's better to get rid of it, set g_CLOCK_PERIOD by default to zero and assert that it is set to something else by user
Tristan Gingold's avatar
Tristan Gingold committed
25
  Done. OK.
Tristan Gingold's avatar
Tristan Gingold committed
26
- shal we name/label all processes?
27
  NO, but...
Tristan Gingold's avatar
Tristan Gingold committed
28 29 30
** VME64xCore_top.vhd
- Add generic/constant for number of supported functions and use it to limit size of ader/adem
  arrays etc, in order to reduce number of warnings in ISE (from ~450 to ~50)
31
  Done.
Tristan Gingold's avatar
Tristan Gingold committed
32 33
- gc_sync_register: does it even make sense? Slide #95 of NASA radiation tolerant design presentation:
  https://indico.cern.ch/event/663761/contributions/2710422/attachments/1537821/2410163/Berg_SynchronousDesign_2017.pdf
34
  No problem, discussion about width postponed.
Tristan Gingold's avatar
Tristan Gingold committed
35 36
*** VME_CR_CSR_Space.vhd
- delete unused port vme_sysfail_ena_o?
Tristan Gingold's avatar
Tristan Gingold committed
37
  Done.
Tristan Gingold's avatar
Tristan Gingold committed
38 39 40

* Simulation
- how am I supposed to run it? A README would help
Tristan Gingold's avatar
Tristan Gingold committed
41
  Done.
Tristan Gingold's avatar
Tristan Gingold committed
42
- why open the GUI at the end of make?
Tristan Gingold's avatar
Tristan Gingold committed
43
  Done.
Tristan Gingold's avatar
Tristan Gingold committed
44
- why keep around VME BFM if you are not using it? Why the SVEC-specific file in the VME BFM?
45
  Removed. To be restored.
Tristan Gingold's avatar
Tristan Gingold committed
46
- why not (also) GHDL if Modelsim is not necessary?
47
  Shouldn't be hard, excercise let to the reader.