udp: bugfix for checksum generation

the UDP checlsum was miscalculated for odd-sized payload. The last byte was not used in calculation. Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

udp: bugfix for checksum generation
the UDP checlsum was miscalculated for odd-sized payload. The last byte was not used in calculation. Signed-off-by: Alessandro Rubini <rubini@gnudd.com>
765443c7 · Alessandro Rubini · 0887cbbe · 765443c7
Commit 765443c7 authored Feb 18, 2016 by Alessandro Rubini
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 3 deletions

udp.c lib/udp.c +3 -3

No files found.
--- a/lib/udp.c
+++ b/lib/udp.c
@@ -40,9 +40,9 @@ void fill_udp(uint8_t * buf, int len, struct wr_udp_addr *uaddr)
 	buf[UDP_CHECKSUM] = 0;
 	buf[UDP_CHECKSUM + 1] = 0;

-	sum =
-	    ipv4_checksum((unsigned short *)(buf + UDP_VIRT_SADDR),
-			  (len - UDP_VIRT_SADDR) / 2);
+	buf[len] = '\0'; /* pad, in case the payload is odd */
+	sum = ipv4_checksum((unsigned short *)(buf + UDP_VIRT_SADDR),
+			    (len + 1 - UDP_VIRT_SADDR) / 2);
 	if (sum == 0)
 		sum = 0xFFFF;