Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in
Toggle navigation
C
Conv TTL Blocking - Gateware
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
1
Issues
1
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
Wiki
Wiki
image/svg+xml
Discourse
Discourse
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Commits
Issue Boards
Open sidebar
Projects
Conv TTL Blocking - Gateware
Commits
a06d4d47
Commit
a06d4d47
authored
Jan 26, 2017
by
Evangelia Gousiou
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
eva_g first comments
parent
7e23550b
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
7 additions
and
3 deletions
+7
-3
eva_g.txt
doc/code-review/v4-27-01-2017/eva_g.txt
+7
-3
No files found.
doc/code-review/v4-27-01-2017/eva_g.txt
View file @
a06d4d47
...
@@ -18,19 +18,23 @@ conv_dyn_burst_ctrl
...
@@ -18,19 +18,23 @@ conv_dyn_burst_ctrl
- line 100: could be: th_array_lgth <= 6 when pwidth = 5 else 15;
- line 100: could be: th_array_lgth <= 6 when pwidth = 5 else 15;
- line 153: could use gc_sync_ffs; otherwise pulse_train_in_f_edge_p could also be initialized if (rst_n_i = '0')
line 122: signals: test, temp_fall not used
and could use another dff before the edge detection for metastability
- line 153: could use gc_sync_ffs (with rst_n_i <= rst_n_i and en_i); otherwise pulse_train_in_f_edge_p could also be initialized if (rst_n_i = '0')
and another dff could be used before the edge detection for metastability
- line 138: en_i not in sensitivity list for sim; process not very clear and the comment "Generate the
- line 138: en_i not in sensitivity list for sim; process not very clear and the comment "Generate the
pulse on rising edge of pulse_burst_i" is not clear.
pulse on rising edge of pulse_burst_i" is not clear.
could the pulse_train_in assignments be moved in the p_thermal_fsm_outputs process or
could the pulse_train_in assignments be moved in the p_thermal_fsm_outputs process or
do sth like "pulse_train_in <= '0' when burst_ctrl_rst = '1' else pulse_burst_i and en_i;"?
do sth like "pulse_train_in <= '0' when burst_ctrl_rst = '1' else pulse_burst_i and en_i;"?
- line 176: "elsif (en_i = '1')" could be skipped; if en_i = '0' there will be no pulse_train_in_r_edge_p
- line 237: 6 could be replaced by a constant
- line 237: 6 could be replaced by a constant
- line 286: should be moved inside the "if" (after line 287)
- line 286: should be moved inside the "if" (after line 287)
- line 299:
i think
this could be skipped, as in this case the FSM will already be in the PULSE_REJECT state
- line 299: this could be skipped, as in this case the FSM will already be in the PULSE_REJECT state
- line 315: should be moved inside an "else"
- line 315: should be moved inside an "else"
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment