Comments after reading MultiBoot module document

652aa622 · Javier Serrano · 73d649b8 · 652aa622
Commit 652aa622 authored Nov 04, 2013 by Javier Serrano
Hide whitespace changes
Inline Side-by-side

Showing with 19 additions and 0 deletions

javier.txt design-review/javier.txt +19 -0

No files found.
--- a/design-review/javier.txt
+++ b/design-review/javier.txt
@@ -50,6 +50,25 @@ Page 5: in table 2 "separate" -> "separated"

 Page 6: "received the address" -> "received address"

+Some comments after reading the MultiBoot module document
+=========================================================
+
+General remark: the list of references is screwed up. It looks like
+the pdf in the repo lacked one pass of latex. 
+
+Page ii: it would be good to define ICAP in the list of abbreviations.
+
+Page 3: I think it's a bit early in the document to show table 2. It
+contains quite a lot of stuff which is actually explained later. 
+
+Page 6. I wonder if the state machine really has 34 states. In that
+case, we might want to look into splitting it into smaller more
+manageable and maintainable state machines. 
+
+Page 9. Reader is left wondering why configuration register reads is
+limited to 16 bits. Only later in the document it is proposed as a
+possible design evolution. Is it so hard? Or is it just useless? 
+
 Todo
 ====