Some very superficial comments on the VBCP block

93209d87 · Javier Serrano · 47f0c8b2 · 93209d87
Commit 93209d87 authored Nov 07, 2013 by Javier Serrano
Hide whitespace changes
Inline Side-by-side

Showing with 13 additions and 4 deletions

javier.txt design-review/javier.txt +13 -4

No files found.
--- a/design-review/javier.txt
+++ b/design-review/javier.txt
@@ -181,7 +181,16 @@ be good for the watchdog to leave some kind of diagnostics trace when
 it fires, so you can identify possible design errors which might go
 unnoticed otherwise.

-Todo
-====
-
- Check important files singled out by Thedi in his message.
+vbcp_wb.vhd
+===========
+
+"done" is a very loose name for a signal. This is not good, and seems
+to be the result of making this signal do three different things. I'd
+seriously consider having three separate signals in the interface of
+the I2C block. E.g. one tells you you received a byte from i2c, so
+something like i2c_data_ready_p (considering it's a pulse) would seem
+appropriate.
+
+Note: somebody else should look at all the nasty things which can
+happen on the WB side, like timeouts and such. I have no time for it
+now and I am not an expert anyway.