Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

This set of commits completely reviews and simplifies the API, fixing
the sequence of allocation/fill/deallocation for buffers.

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Federico Vaga <federico.vaga@gmail.com>

Signed-off-by: Federico Vaga <federico.vaga@gmail.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Federico Vaga <federico.vaga@gmail.com>

At open time, users are expected to pass the total number of samples
they expect to need in their buffer, not the total number of bytes.
The name now matches current use in fald-simple-acq.
Signed-off-by: Federico Vaga <federico.vaga@gmail.com>
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

We need mapaddr and mapsize for munmap() at buffer_release time.
And we need the device pointer (not drivername) in order to route
the get_tstamp method. drivername, if needed, is in the device anyways.
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

SQUASH proto
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

The prototypes for buffer management so far were wrong.

request_buffer() (which up to now both allocates and fille) is going
to only allocate the buffer, so it doesn't need a timeout.

fill_buffer() on the other hand can have a timeout -- although if
you used ack_poll() or acq_start() with no timetout, the filling is
expected to complete immediately.

The current request_buffer(), which still fills is too,
now uses NULL as a timeout, which isn't an argument any more.
./tools/fald-simple-acq works unchanged, as it already passed NULL
as timeout.
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

This reverts commit b6b81e29.

I don't now why, yet, but now multi-shot acquisition acquires a
1-sample error at each shot. So either hw documentation is wrong, or
this patch is incomplete (for example, the hardware value is read back
and used -- this is most likely but I have no time to check now).

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

The file needs a number of code stanzas to be turned into data
structures, however this is delayed to after-1.0.

the commit changes some details only.
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Tipos and minor simplifications.

The only real change here is not stopping acquisition at close time.
I got mad with the auto-start not working because of this. I really think
the program should leave stuff configured, unless explicitly closing it.
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

This is a validation for the fmcadc_acq_poll() function.
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

This commit deals with the acq_start and acq_stop, and adds acq_poll.
It id mainly s simplifying step, removing unneeded checks and
splitting acq_poll out of acq_start (now start calls poll at the end,
as a side effect).

../libtools/fald-simple-acq works unaffected.
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

This commit makes the library consistent with the official design as
far as open and close are concerned. But buffer selection is still missing.

- open_by_lun() is not there in the low-level implementation, because
the function is expected to be library only, and is expected to fall
back to open, after finding the hardware-specific dev_if from the
administratively-set lun value.

- redundant error checking has been removed. For example, NULL names
are as bad as wild-pointer names, so the program should crash, not
receive an error and manage it. I used this policy in several places.

Other changes brought in by this:

- the board list is now static in boards.c

I'll still move something, at the end: open and close are zio-generic, not
board-specific.
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

This picks a master commit of zio, which now includes all the things
needed for this driver.  Since the data_done method now returns integer
(instead of void), the code is fixed in that respect, partly undoing
commit:

   18f2d110 kernel: remove all warnings
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

This set of patches moves functions around, trying to split what is
library-wide from what is zio-wide (i.e., generic code to manage zio
drivers) and board-specific.

This set of patches has no technical change, nor even in the names of
the functions (though some that were static are not static any more).

Later commits in lib/ will change the semantics to match
documentation, rename function and add the missing interfaces. This
set of commits is meant to make later diffs shorter, and thus easier
to review, but I surely forgot something here.

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

This commit makes not change at all, it just copies part of the
original unified header to a new file. And apps use it.
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

When auto-start is selected, buffer allocation happens at inteerupt time,
and thus we need GFP_ATOMIC or the system crashes very badly.
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

This commit verifies that the eeprom data makes sense. If an error
is found, identity calibration is selected instead.

Endian conversion is not there yet.
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

This picks the current fmc-bus master, which is not a release, though.
It is 8 commits after relase 2013-05.1: some cleanups and three
patches we received on lkml (fmc-bus is now in the kernel as
drivers/fmc/).
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Messaging with cset->dev or fa->fmc->hwdev resulted in poor context:
"cset0" in the former case and the carrier name+id in the latter case.
This commit uses fa->fmc->dev, which has more context (more than hwdev
if the carrier is multi-mezzanine).

This also downgrades some dev_err to dev_info (all errors related with
invalid values written to attributes).
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

The hardware acquires pre-samples + the-sample + post-samples while
software uses pre+post (the first "post" is the trigger event.

This had no visible effects as hw just acquired one sample more, but
maybe we'd have error in pathological cases (e.g, a full-ram
acquisition).

This commit also makes trivial unrelated changes in the same code
snippet.
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

The pre_sample was taken by the trigger-instance values, but there
it was still zero (why?).

So this commit picks it from the current control, where it is properly set.

The bug resulted in PRE+POST samples were taken starting from the
trigger position, resulting in some good (but shifted) samples and a
trailing tail of PRE samples not related to this acquisition (at first
run it is random content of unitialized RAM).
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>