drivers: fmc: core: load at24 before probing fmc

In cases where driver modules are not built into the kernel itself, at24 module is not loaded at the desired time, and thus, can cause error when trying to read the eeprom. Also, listing at24 as a soft dependency doesn't solves our problem as it does not guarantees the time at which the module will be loaded. Hence, load the module using request_module(), and throw a kernel warning in syslog if it fails. Signed-off-by: Vaibhav Gupta <vaibhav.gupta@cern.ch>

drivers: fmc: core: load at24 before probing fmc
In cases where driver modules are not built into the kernel itself, at24 module is not loaded at the desired time, and thus, can cause error when trying to read the eeprom. Also, listing at24 as a soft dependency doesn't solves our problem as it does not guarantees the time at which the module will be loaded. Hence, load the module using request_module(), and throw a kernel warning in syslog if it fails. Signed-off-by: Vaibhav Gupta <vaibhav.gupta@cern.ch>
11509b33 · Vaibhav Gupta · 1ecf5cb1 · 11509b33
Commit 11509b33 authored Jun 09, 2023 by Vaibhav Gupta
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 0 deletions

fmc-core.c drivers/fmc/fmc-core.c +5 -0

No files found.
--- a/drivers/fmc/fmc-core.c
+++ b/drivers/fmc/fmc-core.c
@@ -460,6 +460,11 @@ static struct class fmc_class = {

 static int __init fmc_init(void)
 {
+	int ret;
+	ret = request_module("at24");
+	if (ret)
+		pr_warn("fmc: Could not load module 'at24' required for eeprom.");
+
 	return class_register(&fmc_class);
 }