git-svn-id: http://svn.ohwr.org/cern-fip/trunk/hdl/design@138 7f0067c9-7624-46c7-bd39-3fb5400c0213

2ddea0e4 · palvarez · 8ce54353 · 2ddea0e4
Commit 2ddea0e4 authored Jan 25, 2011 by palvarez
Hide whitespace changes
Inline Side-by-side

Showing with 9 additions and 0 deletions

pablo.txt CodeReview_24Jan11/pablo.txt +9 -0

No files found.
--- a/CodeReview_24Jan11/pablo.txt
+++ b/CodeReview_24Jan11/pablo.txt
@@ -14,3 +14,12 @@ WARNING:HDLCompiler:1127 - "E:\ohr\cern-fip\trunk\hdl\design\wf_bits_to_txd.vhd"
 WARNING:HDLCompiler:1127 - "E:\ohr\cern-fip\trunk\hdl\design\wf_engine_control.vhd" Line 424: Assignment to s_id_dat_ctrl_byte ignored, since the identifier is never used


+
+
+wf.crc.vhd
+
+c_GENERATOR_POLY_length and c_VERIFICATION_MASK should both come from a generic
+
+
+wf_cons_bytes_processor.vhd
+line 422. Isn't it possible to check c_CTRL_BYTE_INDEX, c_PDU_BYTE_INDEX and c_LENGTH_BYTE_INDEX upon reception? That would save 24 flip-flops.