major changes in wf_reset_unit

PoR input pin added git-svn-id: http://svn.ohwr.org/cern-fip/trunk/hdl/design@109 7f0067c9-7624-46c7-bd39-3fb5400c0213

major changes in wf_reset_unit
PoR input pin added git-svn-id: http://svn.ohwr.org/cern-fip/trunk/hdl/design@109 7f0067c9-7624-46c7-bd39-3fb5400c0213
35b7480e · egousiou · 8994c7c1 · 35b7480e · 8994c7c1 · 35b7480e
Commit 35b7480e authored Jan 18, 2011 by egousiou
27 changed files
--- a/DualClkRAM.vhd
+++ b/DualClkRAM.vhd
@@ -136,7 +136,6 @@ architecture RAM4K9 of  DualClkRAM is
 --! A Low on this signal makes the output retain data from the previous Read. A High indicates a 
 --! pass-through behavior where the data being written will appear on the output immediately.
  component RAM4K9
    generic (MEMORYFILE:string := "");

--- a/nanofip.vhd
+++ b/nanofip.vhd
--- a/wf_DualClkRAM_clka_rd_clkb_wr.vhd
+++ b/wf_DualClkRAM_clka_rd_clkb_wr.vhd
@@ -64,7 +64,7 @@ use IEEE.NUMERIC_STD.all;     --! conversion functions
 --------------------------------------------------------------------------------------------------- 
 ---/!\----------------------------/!\----------------------------/!\-------------------------/!\---
--                               Sunplify Premier D-2009.12 Warnings                             --
+--                               Synplify Premier D-2009.12 Warnings                             --
 -- -- --  --  --  --  --  --  --  --  --  --  --  --  --  --  -- --  --  --  --  --  --  --  --  --
 --                                         No Warnings                                           --
 ---------------------------------------------------------------------------------------------------
@@ -104,6 +104,7 @@ architecture syn of WF_DualClkRAM_clka_rd_clkb_wr is
 ---------------------------------------------------------------------------------------------------
 --!@brief: component DualClkRam declaration
  component DualClkRam is 
    port(
    CLKA   : in std_logic; 

--- a/wf_bits_to_txd.vhd
+++ b/wf_bits_to_txd.vhd
@@ -71,7 +71,7 @@ use work.WF_PACKAGE.all;      --! definitions of types, constants, entities
 --------------------------------------------------------------------------------------------------- 
 ---/!\----------------------------/!\----------------------------/!\-------------------------/!\---
--                                    Sunplify Premier Warnings                                  --
+--                                    Synplify Premier Warnings                                  --
 -- -- --  --  --  --  --  --  --  --  --  --  --  --  --  --  -- --  --  --  --  --  --  --  --  --
 --                                         No Warnings                                           --
 ---------------------------------------------------------------------------------------------------

--- a/wf_cons_bytes_processor.vhd
+++ b/wf_cons_bytes_processor.vhd
@@ -29,7 +29,7 @@ use work.WF_PACKAGE.all;      --! definitions of types, constants, entities
 -- unit name:  WF_cons_bytes_processor
 --
 --! @brief     The unit is consuming the data bytes that are arriving from the WF_rx_deserializer,
--!            according to the following rules:
+--!            according to the following:
 --!
 --!            o If the consumed variable had been a var_1 or a var_2:
 --!
@@ -43,7 +43,7 @@ use work.WF_PACKAGE.all;      --! definitions of types, constants, entities
 --!              identified and sent to the WF_reset_unit.
 --!
 --!            ------------------------------------------------------------------------------------
--!            Small Reminder:
+--!            Reminder:
 --!
 --!            Consumed RP_DAT frame structure :
 --!             ___________ ______  _______ ________ ________________ _______  ___________ _______
@@ -99,7 +99,7 @@ use work.WF_PACKAGE.all;      --! definitions of types, constants, entities
 ---------------------------------------------------------------------------------------------------
 ---/!\----------------------------/!\----------------------------/!\-------------------------/!\---
--                                    Sunplify Premier Warnings                                  --
+--                                    Synplify Premier Warnings                                  --
 -- -- --  --  --  --  --  --  --  --  --  --  --  --  --  --  -- --  --  --  --  --  --  --  --  --
 --                                         No Warnings                                           --
 ---------------------------------------------------------------------------------------------------
@@ -119,7 +119,7 @@ port (
    -- Signal from the WF_reset_unit
    nfip_urst_i           : in std_logic;                      --! nanoFIP internal reset
-    -- nanoFIP User Interface, WISHBONE Slave
+    -- nanoFIP User Interface, WISHBONE Slave (synchronized with wb_clk)
    wb_clk_i              : in std_logic;                      --! WISHBONE clock
    wb_adr_i              : in  std_logic_vector (9 downto 0); --! WISHBONE address to memory
    wb_cyc_i              : in std_logic;                      --! WISHBONE cycle
@@ -178,7 +178,10 @@ begin
  two    <= to_unsigned (2, two'length);
---------------------------------------------------------------------------------------------------  
+---------------------------------------------------------------------------------------------------
+--                                  Consumed & Consumed Broadcast RAM                            --
+--                    Storage (by the unit) & retreival (by the user) of consumed bytes          --
+--------------------------------------------------------------------------------------------------- 
 -- !@brief Instantiation of a Dual Port Consumed RAM
 --! (for both the consumed and consumed broadcast variables)
@@ -213,38 +216,64 @@ begin
                                          else '0';
 ---------------------------------------------------------------------------------------------------
--!@brief Combinatorial process Bytes_Consumption: Data bytes are consumed according to the
+--                                      Consumed bytes to DAT_O                                  --
--! variable type they belong.
+---------------------------------------------------------------------------------------------------
+--! @brief Instantiation of the unit responsible for the transfering of 2 de-serialized data bytes
+--! to DAT_O;
+  Consumed_Bytes_To_DATO: WF_cons_bytes_to_dato
+  port map(
+    uclk_i            => uclk_i, 
+    nfip_urst_i       => nfip_urst_i, 
+    transfer_byte_p_i => s_slone_write_byte_p,
+    byte_i            => byte_i,
+    ------------------------------------------
+    slone_data_o      => s_slone_data);
+    ------------------------------------------
+--  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  -- -- -- --
+  -- In stand-alone mode the 16 bits DAT_O fills up with the output of the WF_cons_bytes_to_dato
+  -- unit.In memory mode,the lsb of DAT_O contains the output of the reading of the consumed memory
+   data_o <= s_slone_data when slone_i = '1'
+        else "00000000" & s_mem_data_out;  
--! In memory mode the treatment of a var1 is identical to the one of a var2; only the base address
+---------------------------------------------------------------------------------------------------
+--                                        Bytes Processing                                       --
+---------------------------------------------------------------------------------------------------
+--!@brief Combinatorial process Bytes_Processing: Data bytes are consumed according to the
+--! variable type (var_1, var_2, var_rst) they belong.
+--! In memory mode the treatment of a var_1 is identical to the one of a var2; only the base address
 --! of the memory differs.
--! Bytes are consumed even if the Control, PDU_TYPE, Length, CRC & FES bytes or the manch.
+--! Bytes are consumed even if any of the Control, PDU_TYPE, Length, CRC & FES byte or the manch.
 --! encoding of the consumed frame are incorrect.
 --! It is the VAR_RDY signal that signals the user for the validity of the consumed data.
 --! In memory mode, the incoming bytes (byte_i) after the Control byte and before the CRC bytes,
 --! are written in the memory one by one as they arrive, on the moments when the signal
 --! byte_ready_p_i is active.
--! The signals byte_index_i and Length (s_cons_lgth_byte) are used to coordinate which bytes are
+--! The signals byte_index_i and Length (s_cons_lgth_byte) are used to distinguish the Control and
--! written and which are not:
+--! CRC bytes from hte rest:
--! the Control byte, that arrives when byte_index_i = 0, is not written
+--!   o the Control byte arrives when byte_index_i = 0
--! and the CRC bytes are not written by checking the amount of bytes indicated by the Length byte.
+--!   o the CRC bytes arrive $Length bytes after the Length byte
+--! The byte_index_i signal is counting each byte after the FSS and before the FES.
--! The byte_index_i signal is counting each byte after the FSS and before the FES (therefore,
+--! The Length byte (s_cons_lgth_byte) is received from the WF_rx_deserializer when byte_index_i is
--! apart from all the pure data-bytes,it also includes the Control, PDU, Length, MPS & CRC bytes).
+--! equal to 3 and indicates the amount of bytes in the frame after the Control, PDU_TYPE and itself and
--! The Length byte (s_cons_lgth_byte) is received from the WF_rx_deserializer when byte_index_i is equal to 3
--! and indicates the amount of bytes in the frame after the Control, PDU_TYPE and itself and
 --! before the CRC.
 --! In stand-alone mode, in total two bytes of data have to be transferred to the data out bus. The
--! process manages the signal slone_write_byte_p which indicates which of the bytes of the bus
+--! process manages the signal slone_write_byte_p which indicates on which one of the bytes of the
--! (msb: 15 downto 8 or lsb: 7 downto 0) have to be written.
+--! bus (msb: 15 downto 8 or lsb: 7 downto 0) the new incoming byte has to be written.
 --! If the consumed variable is the reset one the process latches the first and second data bytes.
-Bytes_Consumption: process (var_i, byte_index_i, slone_i, byte_i, two,
+Bytes_Processing: process (var_i, byte_index_i, slone_i, byte_i, two,
                            byte_ready_p_i, s_base_addr, s_cons_lgth_byte)
  begin
@@ -396,31 +425,14 @@ Bytes_Consumption: process (var_i, byte_index_i, slone_i, byte_i, two,
 end process;
---------------------------------------------------------------------------------------------------
--! @brief Instantiation of the unit responsible for the transfering of 2 de-serialized data bytes
--! to DAT_O;
-  Consumed_Bytes_To_DATO: WF_cons_bytes_to_dato
-  port map(
-    uclk_i            => uclk_i, 
-    nfip_urst_i       => nfip_urst_i, 
-    transfer_byte_p_i => s_slone_write_byte_p,
-    byte_i            => byte_i,
-    ------------------------------------------
-    slone_data_o      => s_slone_data);
-    ------------------------------------------
--  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  -- -- -- --
-  -- In stand-alone mode the 16 bits DAT_O fills up with the output of the WF_cons_bytes_to_dato
-  -- unit.In memory mode,the lsb of DAT_O contains the output of the reading of the consumed memory 
-   data_o <= s_slone_data when slone_i = '1'
-        else "00000000" & s_mem_data_out;  
+---------------------------------------------------------------------------------------------------
+--                                 Control, PDU_TYPE, Length bytes                               --
 ---------------------------------------------------------------------------------------------------
 --!@brief Synchronous process Buffer_Ctrl_PDU_Length_bytes: Storage of the Control, PDU_TYPE
--! and Length bytes of an incoming RP_DAT frame. The bytes are sent to the WF_cons_outcome
+--! and Length bytes of an incoming RP_DAT frame. The bytes are sent to the WF_cons_frame_validator
--! unit that accordingly enables or not the signals VAR1_RDY (for a var1), VAR2_RDY (for a var2),
+--! unit that validates them and accordingly signals the WF_outcome unit for the activation of the
--! assert_rston_p and rst_nfip_and_fd_p (for a var_rst).
+--! VAR1_RDY(for a var_1), VAR2_RDY(for a var_2), assert_rston_p & rst_nfip_and_fd_p(for a var_rst).
 Buffer_Ctrl_PDU_Length_bytes: process (uclk_i)
  begin                                               

--- a/wf_cons_bytes_to_dato.vhd
+++ b/wf_cons_bytes_to_dato.vhd
@@ -28,14 +28,14 @@ use work.WF_PACKAGE.all;      --! definitions of types, constants, entities
 --
 --
 --! @brief     In stand-alone mode, after the reception of a consumed or consumed broadcast
--!            variable, the unit is responsible for transering the two data-bytes of the variable
+--!            variable, the unit is responsible for transering the two pure-data bytes to the
--!            to the 2-bytes long bus DAT_O.
+--!            2-bytes long bus DAT_O.
 --!            The bytes are put in the bus one by one as they arrive, as the signal 
 --!            transfer_byte_p_i indicates.
 --!
 --!            Note: The validity of these transfered bytes is indicated by the "nanoFIP
--!            User Interface, NON_WISHBONE" signals VAR1_RDY/ VAR2_RDY which arrive after
+--!            User Interface, NON_WISHBONE" signals VAR1_RDY/ VAR2_RDY which arrive later, after
--!            the reception of the FCS and FES bytes.  
+--!            the end of the reception of the consumed frame.  
 --
 --
 --! @author    Pablo Alvarez Sanchez (Pablo.Alvarez.Sanchez@cern.ch) \n
@@ -122,6 +122,7 @@ begin
 --!@brief synchronous process Data_Transfer_To_Dat_o: In stand-alone mode, accrording to the signal
 --! transfer_byte_p_i, the first or second byte of the user interface bus DAT_O takes the
 --! incoming byte byte_i.
 Data_Transfer_To_Dat_o: process (uclk_i) 
  begin
    if rising_edge (uclk_i) then

--- a/wf_cons_frame_validator.vhd
+++ b/wf_cons_frame_validator.vhd
@@ -74,7 +74,7 @@ use work.WF_PACKAGE.all;      --! definitions of types, constants, entities
 --------------------------------------------------------------------------------------------------- 
 ---/!\----------------------------/!\----------------------------/!\-------------------------/!\---
--                               Sunplify Premier D-2009.12 Warnings                             --
+--                               Synplify Premier D-2009.12 Warnings                             --
 -- -- --  --  --  --  --  --  --  --  --  --  --  --  --  --  -- --  --  --  --  --  --  --  --  --
 -- "W CL246  Input port bits 0, 2, 5, 6 of var_i(0 to 6) are unused"                             --
 -- var_i is one-hot encoded and has 7 values.                                                    -- 
@@ -130,11 +130,11 @@ begin
 --------------------------------------------------------------------------------------------------- 
 --!@brief Combinatorial process Consumed_Frame_Validator: validation of an RP_DAT 
--! frame with respect to: Ctrl, PDU, Length bytes as well as CRC, FSS, FES and code violations.
+--! frame with respect to the Ctrl, PDU_TYPE and Length bytes as well as to the CRC, FSS, FES and
--! The bytes cons_ctrl_byte_i, cons_pdu_byte_i, cons_lgth_byte_i that arrive at the beginning of a
+--! to the manchester encoding. The bytes cons_ctrl_byte_i, cons_pdu_byte_i, cons_lgth_byte_i that
--! frame, have been registered and keep their values until the end of a frame.
+--! arrive at the beginning of a frame, have been registered and keep their values until the end
--! The signal rx_fss_crc_fes_manch_ok_p_i, is a pulse at the end of the FES that combines
+--! of it. The signal rx_fss_crc_fes_manch_ok_p_i, is a pulse at the end of the FES that combines
--! the check of the FSS, CRC, FES and the code violations. 
+--! the checks of the FSS, CRC, FES and of the manch. encoding. 
 Consumed_Frame_Validator: process (var_i, cons_ctrl_byte_i, rx_byte_index_i, cons_pdu_byte_i,
                                    rx_fss_crc_fes_manch_ok_p_i, cons_lgth_byte_i)
@@ -191,8 +191,10 @@ begin
 end process;            
  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  -- -- -
-  -- Concurrent signal assignment for the output signals
+  -- Concurrent signal assignments 
  cons_frame_ok_p_o          <= rx_fss_crc_fes_manch_ok_p_i and
                                s_cons_lgth_byte_ok         and
                                s_cons_ctrl_byte_ok         and
@@ -202,6 +204,7 @@ end process;
                                s_cons_ctrl_byte_ok         and
                                s_cons_pdu_byte_ok;
 end architecture rtl;
 --=================================================================================================
 --                                      architecture end

--- a/wf_cons_outcome.vhd
+++ b/wf_cons_outcome.vhd
@@ -28,14 +28,10 @@ use work.WF_PACKAGE.all;      --! definitions of types, constants, entities
 --
 --
 --! @brief     According to the consumed variable that has been received (var_1, var_2, var_rst)
--!            the unit generates the signals:
+--!            and the outcome of the WF_cons_frame_VALIDATOR, the unit generates the signals:
 --!
 --!              o "nanoFIP User Interface, NON_WISHBONE" output signals VAR1_RDY and VAR2_RDY,
--!                according to the variable that is being treated (var_i) and to the
+--!              o rst_nFIP_and_FD_p and assert_RSTON_p, that are inputs to the WF_reset_unit.    
--!                "correct frame" indicator, cons_frame_ok_p_i.
--!
--!              o rst_nFIP_and_FD_p and assert_RSTON_p, according to the data bytes received and to
--!                the "correct frame" indicator, cons_frame_ok_p_i.    
 --
 --
 --! @author    Pablo Alvarez Sanchez (Pablo.Alvarez.Sanchez@cern.ch) \n
@@ -69,7 +65,6 @@ use work.WF_PACKAGE.all;      --! definitions of types, constants, entities
 --------------------------------------------------------------------------------------------------- 
 --
 --! @todo 
--!   -> rename the unit to include actions for var reset. 
 --
 --------------------------------------------------------------------------------------------------- 
@@ -146,37 +141,35 @@ begin
 --! Memory Mode:
  --! Since the three memories (consumed, consumed broadcast, produced) are independant, when a
-  --! produced var is being sent, the user can read form the consumed memories; similarly, when a
+  --! produced var. is being sent, the user can read form the consumed memories; similarly, when a
-  --! consumed variable is being received the user can write to the produced momory.
+  --! consumed var. is being received the user can read from the consumed broadcast memory.
-  --! VAR1_RDY (for consumed vars): signals that the user can safely read from the consumed
+  --! VAR1_RDY (for consumed vars): signals that the user can safely read from the consumed memory.
-  --! variable memory. The signal is asserted only after the reception of a correct RP_DAT frame.
+  --! The signal is asserted only after the reception of a correct RP_DAT frame.
-  --! It is de-asserted after the reception of a correct var1 ID_DAT frame. 
+  --! It is de-asserted after the reception of a correct var_1 ID_DAT frame. 
  --! VAR2_RDY (for broadcast consumed vars): signals that the user can safely read from the
-  --! consumed broadcast variable memory. The signal is asserted only after the reception of a 
+  --! consumed broadcast memory. The signal is asserted only after the reception of a correct
-  --! correct consumed broadcast RP_DAT frame. It is de-asserted after the reception of a correct
+  --! consumed broadcast RP_DAT frame. It is de-asserted after the reception of a correct var_2
-  --! var2 ID_DAT frame. 
+  --! ID_DAT frame. 
 --! Stand-alone Mode:
-  --! In stand-alone mode, the DAT_I and DAT_O buses for the produced and the consumed bytes 
+  --! Similarly, in stand-alone mode, the DAT_I and DAT_O buses for the produced and the consumed 
-  --! are independant. Stand-alone mode does not treat the consumed broadcast variable.
+  --! bytes are independant. Stand-alone mode though does not treat the consumed broadcast variable.
  --! VAR1_RDY (for consumed vars): signals that the user can safely retreive data from the DAT_O
  --! bus. The signal is asserted only after the reception of a correct RP_DAT frame.
-  --! It is de-asserted after the reception of a correct var1 ID_DAT frame(same as in memory mode).
+  --! It is de-asserted after the reception of a correct var_1 ID_DAT frame(same as in memory mode).
  --! VAR2_RDY (for broadcast consumed vars): stays always deasserted.
 --! Note: A correct consumed RP_DAT frame is signaled by the cons_frame_ok_p_i, whereas a correct
 --! ID_DAT frame along with the variable it contained is signaled by the var_i.
--! For consumed variables, var_i gets its value (var1, var2, var_rst) after the reception of a
+--! For consumed variables, var_i gets its value (var_1, var_2, var_rst) after the reception of a
 --! correct ID_DAT frame and of a correct FSS of the corresponding RP_DAT frame and it retains it
 --! unitl the end of the reception.
  VAR_RDY_Generation: process (uclk_i) 
  begin
    if rising_edge (uclk_i) then
@@ -192,7 +185,7 @@ begin
        when var_1 =>                              -- nanoFIP consuming
                                                   --------------------   
-          var1_rdy_o        <= '0';                -- while consuming a var1, VAR1_RDY is 0
+          var1_rdy_o        <= '0';                -- while consuming a var_1, VAR1_RDY is 0
          var2_rdy_o        <= s_var2_received;    -- VAR2_RDY retains its value
@@ -208,7 +201,7 @@ begin
      --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  -- --  --  --  --  --  --  --  --
        when var_2 =>                             -- nanoFIP consuming broadcast     
                                                  ------------------------------ 
-          var2_rdy_o        <= '0';               -- while consuming a var2, VAR2_RDY is 0
+          var2_rdy_o        <= '0';               -- while consuming a var_2, VAR2_RDY is 0
          var1_rdy_o        <= s_var1_received;   -- VAR1_RDY retains its value
          if slone_i = '0' and cons_frame_ok_p_d1 = '1' then        
@@ -250,14 +243,14 @@ begin
    end if;
  end process;
---------------------------------------------------------------------------------------------------
 ---------------------------------------------------------------------------------------------------
 --!@ brief: Generation of the signals s_rst_nfip_and_fd : signals that the 1st byte of a consumed 
 --!                                                        reset var contains the station address   
 --!                                  and s_assert_rston : signals that the 2nd byte of a consumed
 --!                                                        reset var contains the station address 
-  Reset_Signals: process (uclk_i) 
+  Cons_Reset_Signals: process (uclk_i) 
  begin
    if rising_edge (uclk_i) then

--- a/wf_consumption.vhd
+++ b/wf_consumption.vhd
@@ -27,7 +27,7 @@ use work.WF_PACKAGE.all;      --! definitions of types, constants, entities
 ---------------------------------------------------------------------------------------------------
 --
 --
--! @brief     The unit gathers the main nanoFIP actions with respect to data consumption.
+--! @brief     The unit gathers the main actions that regard data consumption.
 --!            It instantiates the units:
 --!
 --!              o WF_rx_deglitcher        : for the filtering of the "nanoFIP FIELDRIVE"
@@ -36,41 +36,42 @@ use work.WF_PACKAGE.all;      --! definitions of types, constants, entities
 --!              o WF_cons_bytes_processor : for the manipulation of the data as they arrive (mainly
 --!                                          registering them to the RAM or putting them to DAT_O)
 --!              o WF_cons_frame_validator : for the validation of the consumed frame, at the end of
--!                                          of its arrival (checking mainly the CRC & manch. encoding)
+--!                                          of its arrival (in terms of FSS, Ctrl, PDU_TYPE, Lgth,
--!              o WF_cons_outcome         : for the treatment of the "nanoFIP User Interface, NON-
+--!                                          CRC bytes & manch. encoding)
+--!              o WF_cons_outcome         : for the generation of the "nanoFIP User Interface, NON-
 --!                                          WISHBONE" outputs VAR1_RDY and VAR2_RDY (for var_1, var_2)
 --!                                          or of the internal signals for the nanoFIP and FIELDRIVE
 --!                                          resets (for a var_rst)  
 --!
--!                            _________________________________
+--!                                __       _________________________________
--!                           |                                 | 
+--!                               |        |                                 | 
--!                           |         WF_cons_outcome         | 
+--!                               |        |         WF_cons_outcome         | 
--!                           |_________________________________|
+--!                               |        |_________________________________|
--!                                           ^
+--!                           Level 2                       ^
--!                            _________________________________
+--!                               |         _________________________________
--!                           |                                 | 
+--!                               |        |                                 | 
--!                           |     WF_cons_frame_validator     | 
+--!                               |        |     WF_cons_frame_validator     | 
--!                           |_________________________________|
+--!                               |__      |_________________________________|
--!                                            ^
+--!                                                         ^
--!                            _________________________________
+--!                                __       _________________________________
--!                           |                                 | 
+--!                               |        |                                 | 
--!                           |      WF_cons_bytes_processor    |
+--!                           Level 1      |      WF_cons_bytes_processor    |
--!                           |                                 | 
+--!                               |        |                                 | 
--!                           |_________________________________|
+--!                               |__      |_________________________________|
--!                                            ^
+--!                                                         ^
--!                            _________________________________
+--!                                __       _________________________________
--!                           |                                 | 
+--!                               |        |                                 | 
--!                           |        WF_rx_deserializer       |
+--!                               |        |        WF_rx_deserializer       |
--!                           |                                 | 
+--!                               |        |                                 | 
--!                           |_________________________________|
+--!                               |        |_________________________________|
--!                                            ^
+--!                            Level 0                      ^
--!                            _________________________________
+--!                               |         _________________________________
--!                           |                                 | 
+--!                               |        |                                 | 
--!                           |         WF_rx_deglitcher        |
+--!                               |        |         WF_rx_deglitcher        |
--!                           |_________________________________|
+--!                               |__      |_________________________________|
--!
+--! 
--!             _______________________________________________________________
+--!                          _______________________________________________________________
--!            0__________________________FIELDBUS____________________________O    
+--!                         0__________________________FIELDBUS____________________________O    
 --1
 --!
 --!            Note: In the entity declaration of this unit, below each input signal, we mark
@@ -112,7 +113,7 @@ use work.WF_PACKAGE.all;      --! definitions of types, constants, entities
 --------------------------------------------------------------------------------------------------- 
 ---/!\----------------------------/!\----------------------------/!\-------------------------/!\---
--                               Sunplify Premier D-2009.12 Warnings                             --
+--                               Synplify Premier D-2009.12 Warnings                             --
 -- -- --  --  --  --  --  --  --  --  --  --  --  --  --  --  -- --  --  --  --  --  --  --  --  --
 --                                         No Warnings!                                          --
 ---------------------------------------------------------------------------------------------------
@@ -253,7 +254,8 @@ begin
 --                               Consumption Level 0: Deglitcher                                 --
 ---------------------------------------------------------------------------------------------------
 --! @brief Instantiation of the WF_rx_deglitcher unit that applies a glitch filter to the "nanoFIP
--! FIELDRIVE" input signal fd_rxd
+--! FIELDRIVE" input signal fd_rxd.
  Consumption_Level_0_Deglitcher : WF_rx_deglitcher 
  generic map (c_DEGLITCH_LGTH => 10)
  port map(
@@ -275,6 +277,7 @@ begin
 --------------------------------------------------------------------------------------------------- 
 --! @brief Instantiation of the WF_rx_deserializer unit that deserializes the deglitched fd_rxd
 --! and constructs bytes of data.
  Consumption_Level_0_Deserializer: WF_rx_deserializer 
  port map (
    uclk_i                   => uclk_i,
@@ -304,6 +307,7 @@ begin
 --! @brief Instantiation of the WF_cons_bytes_processor unit that is "consuming" data bytes
 --! arriving from the WF_rx_deserializer, by registering them to the Consumed memories or by
 --! transferring them to the "nanoFIP User Interface, NON_WISHBONE" output bus DAT_O.
  Consumption_Level_1_bytes_processor : WF_cons_bytes_processor 
  port map(
    uclk_i                => uclk_i,
@@ -334,6 +338,7 @@ begin
 --! @brief Instantiation of the WF_cons_frame_validator unit, responsible for the validation of a
 --! received RP_DAT frame with respect to the correctness of the Control, PDU_TYPE and Length
 --! bytes of the Manchester encoding.
  Consumption_Level_2_Frame_Validator: WF_cons_frame_validator
  port map(
    cons_ctrl_byte_i            => s_cons_ctrl_byte, 
@@ -354,7 +359,8 @@ begin
 --------------------------------------------------------------------------------------------------- 
 --! @brief Instantiation of the WF_cons_outcome unit that is generating :
 --! the "nanoFIP User Interface, NON_WISHBONE" output signals VAR1_RDY & VAR2_RDY (for a var_1/2)
--! or the nanoFIP internal signals rst_nFIP_and_FD_p and assert_RSTON_p          (for a var_rst)
+--! or the nanoFIP internal signals rst_nFIP_and_FD_p and assert_RSTON_p          (for a var_rst).
  Consumption_Level_2_Outcome : WF_cons_outcome
  port map (
    uclk_i                => uclk_i,

--- a/wf_crc.vhd
+++ b/wf_crc.vhd
@@ -27,8 +27,9 @@ use work.WF_PACKAGE.all;     --! definitions of types, constants, entities
 ---------------------------------------------------------------------------------------------------
 --
 --
--! @brief     The unit includes the modules for the generation of the CRC of serial data,
+--! @brief     The unit creates the modules:
--!            as well as for the verification of an incoming CRC syndrome.
+--!              o for the generation of the CRC of serial data,
+--!              o for the verification of an incoming CRC syndrome.
 --
 --
 --! @author    Pablo Alvarez Sanchez (Pablo.Alvarez.Sanchez@cern.ch)\n
@@ -68,7 +69,7 @@ use work.WF_PACKAGE.all;     --! definitions of types, constants, entities
 ---------------------------------------------------------------------------------------------------
 ---/!\----------------------------/!\----------------------------/!\-------------------------/!\---
--                               Sunplify Premier D-2009.12 Warnings                             --
+--                               Synplify Premier D-2009.12 Warnings                             --
 -- -- --  --  --  --  --  --  --  --  --  --  --  --  --  --  -- --  --  --  --  --  --  --  --  --
 --                                         No Warnings                                           --
 ---------------------------------------------------------------------------------------------------
@@ -78,7 +79,7 @@ use work.WF_PACKAGE.all;     --! definitions of types, constants, entities
 --!                                 Entity declaration for WF_crc
 --=================================================================================================
 entity WF_crc is
-generic (c_GENERATOR_POLY_length : natural := 16);   --! default value
+generic (c_GENERATOR_POLY_length : natural := 16);  --! default value
 port (
  -- INPUTS 
    -- nanoFIP User Interface, General signals
@@ -89,13 +90,13 @@ port (
    -- Signals from the WF_rx_deserializer/ WF_tx_serializer units
    data_bit_i         : in std_logic;              --! incoming data bit stream
-    data_bit_ready_p_i : in std_logic;              --! indicator of sampling time for data_bit_i
+    data_bit_ready_p_i : in std_logic;              --! indicates the sampling moment of data_bit_i
    start_crc_p_i      : in std_logic;              --! beginning of the CRC calculation
  -- OUTPUTS 
    -- Signal to the WF_rx_deserializer unit
-    crc_ok_p           : out std_logic;             --! signaling of a correct received CRC syndrome
+    crc_ok_p           : out std_logic;             --! signals a correct received CRC syndrome
    -- Signal to the WF_tx_serializer unit
    crc_o              : out  std_logic_vector (c_GENERATOR_POLY_length-1 downto 0)--!calculated CRC
@@ -172,8 +173,8 @@ crc_o <= not s_q;
 --!@brief Combinatorial process Syndrome_Verification: On the reception, the CRC is being
 --! calculated as data is arriving (same as in the transmission) and it is being compared to the
 --! predefined c_VERIFICATION_MASK. When the CRC calculated from the received data matches the
--! c_VERIFICATION_MASK, it is implied that a correct CRC word has been received and the signal
+--! c_VERIFICATION_MASK, it is implied that a correct CRC word has been received for the preceded
--! crc_ok_p gives a pulse. 
+--! data and the signal crc_ok_p gives a pulse. 
 Syndrome_Verification: process (s_q, s_crc_bit_ready_p)

--- a/wf_decr_counter.vhd
+++ b/wf_decr_counter.vhd
@@ -57,7 +57,7 @@ use IEEE.NUMERIC_STD.all;     --! conversion functions
 --------------------------------------------------------------------------------------------------- 
 ---/!\----------------------------/!\----------------------------/!\-------------------------/!\---
--                               Sunplify Premier D-2009.12 Warnings                             --
+--                               Synplify Premier D-2009.12 Warnings                             --
 -- -- --  --  --  --  --  --  --  --  --  --  --  --  --  --  -- --  --  --  --  --  --  --  --  --
 --                                         No Warnings                                           --
 ---------------------------------------------------------------------------------------------------
@@ -105,6 +105,7 @@ begin
 ---------------------------------------------------------------------------------------------------
  -- Synchronous process Decr_Counter
  Decr_Counter: process (uclk_i)
  begin
    if rising_edge (uclk_i) then
@@ -124,8 +125,10 @@ begin
    end if;
  end process;
 --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  -- 
  -- Concurrent assignments for output signals
  counter_o         <= s_counter;
  counter_is_zero_o <= '1' when s_counter = to_unsigned(0,s_counter'length) else '0';

--- a/wf_engine_control.vhd
+++ b/wf_engine_control.vhd
--- a/wf_incr_counter.vhd
+++ b/wf_incr_counter.vhd
@@ -102,6 +102,7 @@ begin
 --------------------------------------------------------------------------------------------------- 
  -- Synchronous process Incr_Counter
  Incr_Counter: process (uclk_i)
  begin
    if rising_edge (uclk_i) then
@@ -119,8 +120,10 @@ begin
    end if;
  end process;
 --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  -- 
  -- Concurrent assignments for output signals
  counter_o         <= s_counter;
  counter_is_full_o <= '1' when s_counter = c_COUNTER_FULL else '0';

--- a/wf_inputs_synchronizer.vhd
+++ b/wf_inputs_synchronizer.vhd
@@ -69,7 +69,7 @@ use work.WF_PACKAGE.all;      --! definitions of types, constants, entities
 --------------------------------------------------------------------------------------------------- 
 ---/!\----------------------------/!\----------------------------/!\-------------------------/!\---
--                               Sunplify Premier D-2009.12 Warnings                             --
+--                               Synplify Premier D-2009.12 Warnings                             --
 -- -- --  --  --  --  --  --  --  --  --  --  --  --  --  --  -- --  --  --  --  --  --  --  --  --
 --                                         No Warnings                                           --
 ---------------------------------------------------------------------------------------------------
@@ -99,7 +99,7 @@ entity WF_inputs_synchronizer is
    rate_a_i          : in std_logic_vector(1 downto 0);
    subs_a_i          : in std_logic_vector(7 downto 0);
-    -- nanoFIP User Interface, WISHBONE Slave 
+    -- nanoFIP User Interface, WISHBONE Slave (synchronized with wb_clk) 
    wb_clk_i          : in std_logic;                   --! WISHBONE clock
    dat_a_i           : in std_logic_vector(15 downto 0);
    wb_adr_a_i        : in std_logic_vector(9 downto 0);
@@ -134,7 +134,7 @@ entity WF_inputs_synchronizer is
    rate_o            : out std_logic_vector(1 downto 0);
    subs_o            : out std_logic_vector(7 downto 0);
-    -- nanoFIP User Interface, WISHBONE Slave 
+    -- nanoFIP User Interface, WISHBONE Slave
    wb_adri_o         : out std_logic_vector(9 downto 0);
    wb_cyc_o          : out std_logic;
    wb_dati_o         : out std_logic_vector(7 downto 0);
@@ -417,7 +417,6 @@ begin
  p3_lgth_o         <= s_p3_lgth_d3;
--------------------------------------------------------------------------------------------------
 end architecture rtl;
 --=================================================================================================

--- a/wf_manch_code_viol_check.vhd
+++ b/wf_manch_code_viol_check.vhd
@@ -7,7 +7,7 @@
 --________________________________________________________________________________________________|
 ---------------------------------------------------------------------------------------------------
--! @file WF_rx_manch_code_check.vhd                                                            |
+--! @file WF_rx_manch_code_check.vhd                                                              |
 ---------------------------------------------------------------------------------------------------
 --! standard library
@@ -31,15 +31,22 @@ use work.WF_PACKAGE.all;      --! definitions of types, constants, entities
 --!            Manchester 2 (manch.) code violation is detected.
 --!            It is assumed that a violation happens if after a half-bit-clock period (plus 2 uclk
 --!            periods), the incoming signal has not had a transition.
--!            Note: the term sample_manch_bit_p refers to the moments when a manch. encoded bit
+--!
--!            should be sampled (before and after a significant edge), whereas the 
+--!            Remark: We refer to
--!            sample_bit_p includes only the sampling of the 1st part, before the transition. 
+--!              o a significant edge                : for the edge of a manch. encoded bit
--!            Example:
+--!                (bit 0: __|--, bit 1: --|__)
--!                    bit                : 0 
+--!              o the sampling of a manch. bit      : for the moments when a manch. encoded bit
--!                    manch. encoded     : _|-
+--!                should be sampled, before and after a significant edge. The period of this
--!                    sample_manch_bit_p : ^ ^
+--!                sampling is that of the half-bit-clock.
--!                    sample_bit_p       : ^    (this sampling will give the 0)
+--!              o the sampling of a bit             : for the sampling of only the 1st part,
+--!                before the transition (the period is the double of the manch. sampling) 
+--!
+--!                Example:
+--!                  bits               :   0     1 
+--!                  manch. encoded     : __|-- --|__
+--!                  significant edge   :  ^     ^
+--!                  sample_manch_bit_p :  ^ ^   ^ ^ 
+--!                  sample_bit_p       :  ^     ^   (this sampling will give the 0 and the 1)
 --
 --
 --! @author    Pablo Alvarez Sanchez (Pablo.Alvarez.Sanchez@cern.ch)
@@ -116,8 +123,7 @@ begin
 ---------------------------------------------------------------------------------------------------
 --!@brief Synchronous process Check_Code_Violations: in order to check for code violations, the
 --! input signal is delayed by half-bit-clock period (serial_input_signal_d).
--! The signal check_code_viol_p is a pulse occuring 2 uclk periods after a manch. transition is
+--! The signal check_code_viol_p is a pulse occuring 2 uclk periods after a manch. edge is expected.
--! expected.
 --! As the following drawing roughly indicates, a violation exists if the signal and its delayed
 --! version are identical on the check_code_viol_p moments.
@@ -150,6 +156,7 @@ begin
 --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  -- 
  -- Concurrent signal assignment
  manch_code_viol_p_o                <= s_check_code_viol_p and 
                                        (not (serial_input_signal_i xor s_serial_input_signal_d));

--- a/wf_manch_encoder.vhd
+++ b/wf_manch_encoder.vhd
@@ -64,7 +64,7 @@ use IEEE.NUMERIC_STD.all;     --! conversion functions
 --------------------------------------------------------------------------------------------------- 
 ---/!\----------------------------/!\----------------------------/!\-------------------------/!\---
--                               Sunplify Premier D-2009.12 Warnings                             --
+--                               Synplify Premier D-2009.12 Warnings                             --
 -- -- --  --  --  --  --  --  --  --  --  --  --  --  --  --  -- --  --  --  --  --  --  --  --  --
 --                                         No Warnings                                           --
 ---------------------------------------------------------------------------------------------------

--- a/wf_model_constr_decoder.vhd
+++ b/wf_model_constr_decoder.vhd
@@ -77,7 +77,7 @@ use work.WF_PACKAGE.all;      --! definitions of types, constants, entities
 ---------------------------------------------------------------------------------------------------
 ---/!\----------------------------/!\----------------------------/!\-------------------------/!\---
--                               Sunplify Premier D-2009.12 Warnings                             --
+--                               Synplify Premier D-2009.12 Warnings                             --
 -- -- --  --  --  --  --  --  --  --  --  --  --  --  --  --  -- --  --  --  --  --  --  --  --  --
 --                                         No Warnings                                           --
 ---------------------------------------------------------------------------------------------------
@@ -141,7 +141,6 @@ begin
 --! s_constr_stage1. On a third uclk tick the loaded odd and even values are combined to give
 --! the decoded outputs (model_id_dec_o & constr_id_dec_o).
  Model_Constructor_Decoder: process (uclk_i)
  begin
    if rising_edge (uclk_i) then                    -- initializations
@@ -178,8 +177,10 @@ begin
    end if;
  end process;
 ---------------------------------------------------------------------------------------------------
 --!@brief Instantiation of a counter WF_incr_counter
  Free_Counter: WF_incr_counter
  generic map(g_counter_lgth => 2)
  port map(
@@ -195,6 +196,7 @@ begin
 ---------------------------------------------------------------------------------------------------
 --!@brief Concurrent signal assignment for the output select_id_o
  select_id_o <=  ((not s_counter(0)) & s_counter(0)); -- 2 opposite clocks generated using
                                                       -- the LSB of the counter 
                                                       -- uclk_i: |-|__|-|__|-|__|-|__|-|__|-|_

--- a/wf_package.vhd
+++ b/wf_package.vhd
@@ -179,9 +179,9 @@ package WF_package is
  constant c_BIT_RATE_UCLK_TICKS_31_25Kbit: unsigned := 
                          to_unsigned((32000 / integer(C_QUARTZ_PERIOD)),C_PERIODS_COUNTER_LENGTH);
-  constant c_BIT_RATE_UCLK_TICKS_1_Mbit: unsigned :=
+  constant c_BIT_RATE_UCLK_TICKS_1_Mbit: unsigned    :=
                          to_unsigned((1000 / integer(C_QUARTZ_PERIOD)),C_PERIODS_COUNTER_LENGTH);
-  constant c_BIT_RATE_UCLK_TICKS_2_5_Mbit: unsigned :=
+  constant c_BIT_RATE_UCLK_TICKS_2_5_Mbit: unsigned  :=
                          to_unsigned((400 /integer(C_QUARTZ_PERIOD)),C_PERIODS_COUNTER_LENGTH);
  -- Creation of a table with the c_BIT_RATE_UCLK_TICKS info per bit rate
@@ -193,6 +193,9 @@ package WF_package is
                           2 => (c_BIT_RATE_UCLK_TICKS_2_5_Mbit),
                           3 => (c_BIT_RATE_UCLK_TICKS_2_5_Mbit));
+  constant c_2_PERIODS_COUNTER_LENGTH : natural := 12;-- length of a counter counting 4 reception/
+                                                      -- transmission period
 ---------------------------------------------------------------------------------------------------
 --                     Constants & Types regarding the turnaround and silence times              --
@@ -678,11 +681,11 @@ end component WF_production;
  component WF_reset_unit 
  port (
    uclk_i              : in std_logic; 
-    urst_i              : in  std_logic; 
+    rstin_i             : in std_logic; 
-    rate_i              : in std_logic_vector (1 downto 0);
    urst_r_edge_i       : in std_logic;
+    rstpon_i            : in std_logic;
+    rate_i              : in std_logic_vector (1 downto 0);
    var_i               : in t_var;    
-    subs_i              : in  std_logic_vector (7 downto 0);
    rst_nFIP_and_FD_p_i : in std_logic;
    assert_RSTON_p_i    : in std_logic;
    ---------------------------------------------------------------

--- a/wf_prod_bytes_retriever.vhd
+++ b/wf_prod_bytes_retriever.vhd
@@ -447,6 +447,7 @@ begin
 --!@brief Synchronous process Delay_mem_wr_en: since the input buses wb_data_i and wb_addr_i are
 --! the triply buffered versions of the DAT_I and ADR_I, the signal write_en_portb_i has to be delayed
 --! too. As write_en_portb_i we use the wb_ack_prod_p signal.
  Delay_mem_wr_en: process (wb_clk_i) 
  begin
    if rising_edge (wb_clk_i) then

--- a/wf_prod_data_lgth_calc.vhd
+++ b/wf_prod_data_lgth_calc.vhd
@@ -27,13 +27,25 @@ use work.WF_PACKAGE.all;      --! definitions of types, constants, entities
 ---------------------------------------------------------------------------------------------------
 --
 --
--! @brief     Calculation of the total amount of data bytes that have to be transferreed when a
+--! @brief     Calculation of the total amount of bytes, after the FSS and before the FCS, that
--!            variable is produced (including the RP_DAT.Control, RP_DAT.Data.MPS_status and
+--!            have to be transferreed when a variable is produced. In detail, the calculation
--!            RP_DAT.Data.nanoFIP_status bytes)
+--!            takes into account the: RP_DAT.Control, RP_DAT.Data.PDU_TYPE, RP_DAT.Data.Length,
--
+--!            RP_DAT.Data.MPS_status, RP_DAT.Data.nanoFIP_status bytes as well as the user-data
--
+--!            bytes described by the P3_LGTH.
--! @author    Pablo Alvarez Sanchez (Pablo.Alvarez.Sanchez@cern.ch)
+--!
--!            Evangelia Gousiou     (Evangelia.Gousiou@cern.ch)
+--!            ------------------------------------------------------------------------------------
+--!            Reminder
+--!
+--!            Produced RP_DAT frame structure :
+--!             ___________ ______  _______ ______ _________________ _______ _______  ___________ _______
+--!            |____FSS____|_Ctrl_||__PDU__|_LGTH_|__..User-Data..__|_nstat_|__MPS__||____FCS____|__FES__|
+--!
+--!                                               |-----P3_LGTH-----|
+--!
+--
+--
+--! @author    Pablo Alvarez Sanchez (Pablo.Alvarez.Sanchez@cern.ch) \n
+--!            Evangelia Gousiou     (Evangelia.Gousiou@cern.ch)     \n
 --
 --
 --! @date      09/12/2010
@@ -66,7 +78,7 @@ use work.WF_PACKAGE.all;      --! definitions of types, constants, entities
 --------------------------------------------------------------------------------------------------- 
 ---/!\----------------------------/!\----------------------------/!\-------------------------/!\---
--                               Sunplify Premier D-2009.12 Warnings                             --
+--                               Synplify Premier D-2009.12 Warnings                             --
 -- -- --  --  --  --  --  --  --  --  --  --  --  --  --  --  -- --  --  --  --  --  --  --  --  --
 --                                         No Warnings                                           --
 ---------------------------------------------------------------------------------------------------
@@ -112,11 +124,11 @@ signal s_prod_data_length, s_p3_length_decoded : unsigned(7 downto 0);
 begin
 ---------------------------------------------------------------------------------------------------
--!@brief: Combinatorial process data_length_calcul: calculation of the total amount of data
+--!@brief: Combinatorial process data_length_calcul: calculation of the amount of bytes, after the
--! bytes that have to be transferreed when a variable is produced, including the RP_DAT.Control as
+--! FSS and before the FCS, that have to be transferreed when a variable is produced. In the case  
--! well as the RP_DAT.Data.MPS_status and RP_DAT.Data.nanoFIP_status bytes. In the case of the 
+--! of the presence and the identification variables, the data length is predefined in the WF_package.
--! presence and the identification variables, the data length is predefined in the WF_package.
+--! In the case of a var3 the inputs slone, nostat and p3_lgth[] are accounted for the calculation.
--! In the case of a var3 the inputs slone, nostat and p3_lgth[] are accounted for the calculation. 
  data_length_calcul: process (var_i, s_p3_length_decoded, slone_i, nostat_i, p3_lgth_i)
  begin
@@ -142,15 +154,15 @@ begin
      -- data length calculation according to the operational mode (memory or stand-alone)
      -- in slone mode                   2 bytes of user-data are produced(independantly of p3_lgth)
-      -- to these there should be added: 1 byte RP_DAT.Control
+      -- to these there should be added: 1 byte Control
-      --                                 1 byte PDU
+      --                                 1 byte PDU_TYPE
      --                                 1 byte Length
      --                                 1 byte MPS status
      --                      optionally 1 byte nFIP status
      -- in memory mode the signal      "s_p3_length_decoded" indicates the amount of user-data
-      -- to these, there should be added 1 byte RP_DAT.Control
+      -- to these, there should be added 1 byte Control
-      --                                 1 byte PDU
+      --                                 1 byte PDU_TYPE
      --                                 1 byte Length
      --                                 1 byte MPS status
      --                      optionally 1 byte nFIP status  

--- a/wf_prod_permit.vhd
+++ b/wf_prod_permit.vhd
@@ -22,7 +22,7 @@ use work.WF_PACKAGE.all;      --! definitions of types, constants, entities
 ---------------------------------------------------------------------------------------------------
 --                                                                                               --
--                                          WF_prod_permit                                       --
+--                                        WF_prod_permit                                         --
 --                                                                                               --
 ---------------------------------------------------------------------------------------------------
 --
@@ -112,7 +112,7 @@ begin
 --! VAR3_RDY (for produced vars): signals that the user can safely write to the produced variable
 --! memory or access the DAT_I bus. It is deasserted right after the end of the reception of a
--! correct var3 ID_DAT frame and stays de-asserted until the end of the transmission of the
+--! correct var_3 ID_DAT frame and stays de-asserted until the end of the transmission of the
 --! corresponding RP_DAT from nanoFIP.
 --! Note: A correct ID_DAT frame along with the variable it contained is signaled by the var_i.
@@ -148,7 +148,6 @@ begin
  end process;
 end architecture rtl;
 --=================================================================================================
 --                                      architecture end

--- a/wf_production.vhd
+++ b/wf_production.vhd
@@ -117,7 +117,7 @@ entity WF_production is
      var3_acc_i              : in std_logic;
 	--  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --
-    -- nanoFIP FIELDRIVE
+    -- nanoFIP FIELDRIVE (synchronized with uclk)
      --! WF_status_bytes_gen : for the nanoFIP status byte, bits 6, 7
      fd_txer_i               : in  std_logic;
@@ -178,7 +178,7 @@ entity WF_production is
      var3_rdy_o              : out std_logic; --! signals the user that data can safely be written
 	--  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --
-    -- nanoFIP User Interface, WISHBONE Slave output
+    -- nanoFIP User Interface, WISHBONE Slave (synchronized with wb_clk) output
      wb_ack_prod_p_o         : out std_logic  --! WISHBONE acknowledge
      );

--- a/wf_reset_unit.vhd
+++ b/wf_reset_unit.vhd
--- a/wf_rx_deglitcher.vhd
+++ b/wf_rx_deglitcher.vhd
@@ -25,18 +25,25 @@ use IEEE.NUMERIC_STD.all;    --! conversion functions
 ---------------------------------------------------------------------------------------------------
 --
 --
--! @brief     The unit applies a glitch filter; it follows each manchester bit of the "nanoFIP
+--! @brief     The unit applies a glitch filter; it follows each Manchester 2 encoded bit (manch.)
--!            FIELDRIVE" input signal fd_rxd (synchronized with uclk), counts the number of zeros
+--!            of the "nanoFIP FIELDRIVE" input signal fd_rxd (synchronized with uclk), counts the 
--!            and ones throughout its duration and finally outputs the majority. The output
+--!            number of zeros and ones throughout its duration and finally outputs the majority. 
--!            deglitched signal is one half-bit-clock period later than the input.
+--!            The output deglitched signal is one half-bit-clock period later than the input.
--!            Note: the term sample_manch_bit_p refers to the moments when a manch. encoded bit
+--!
--!            should be sampled (before and after a significant edge), whereas the 
+--!            Remark: We refer to
--!            sample_bit_p includes only the sampling of the 1st part, before the transition. 
+--!              o a significant edge                : for the edge of a manch. encoded bit
--!            Example:
+--!                (bit 0: _|-, bit 1: -|_)
--!                    bit                : 0 
+--!              o the sampling of a manch. bit      : for the moments when a manch. encoded bit
--!                    manch. encoded     : _|-
+--!                should be sampled, before and after a significant edge
--!                    sample_manch_bit_p : ^ ^
+--!              o the sampling of a bit             : for the sampling of only the 1st part,
--!                    sample_bit_p       : ^    (this sampling will give the 0)
+--!                before the transition. 
+--!
+--!                Example:
+--!                  bits               :  0   1 
+--!                  manch. encoded     : _|- -|_
+--!                  significant edge   :  ^   ^
+--!                  sample_manch_bit_p : ^ ^ ^ ^ 
+--!                  sample_bit_p       : ^   ^   (this sampling will give the 0 and the 1)
 --
 --
 --! @author	   Pablo Alvarez Sanchez (Pablo.Alvarez.Sanchez@cern.ch) \n
@@ -126,9 +133,9 @@ begin
 ---------------------------------------------------------------------------------------------------
--! Synchronous process: Zeros_and_Ones_counter: For each manchester bit (between two
+--! Synchronous process: Zeros_and_Ones_counter: For each manch. encoded bit (between two
--! sample_manch_bit_p_i pulses) at each uclk tick, the signed counter decreases by one if rxd is
+--! sample_manch_bit_p_i pulses) at each uclk tick, the signed counter decreases by one if rxd_i
--! one or increases by one if rxd is zero.
+--! is "1" and increases by one if rxd_i is "0".
 Zeros_and_Ones_counter: process (uclk_i)
  begin
@@ -150,12 +157,12 @@ Zeros_and_Ones_counter: process (uclk_i)
  end if;
 end process;
 ---------------------------------------------------------------------------------------------------
--! Synchronous process Filtering: On the arrival of a new manchester bit, if the number of ones 
+--! Synchronous process Filtering: On the arrival of a new manch. bit, if the number of ones 
 --! that has been measured (for the bit that has already passed) is more than the number of zeros,
--! the filtered output signal is zero (until the new manchester bit), otherwise one. 
+--! the filtered output is set to zero (until the new manch. bit), otherwise to one. 
--! The filtered signal is one half-bit-clock cycle (+2 uclk cycles) late with respect to the
+--! The filtered signal is one half-bit-clock cycle (+2 uclk cycles) late with respect to its input.
--! synchronized fd_rxd.
 Filtering: process (uclk_i)
  begin
@@ -176,9 +183,10 @@ Filtering: process (uclk_i)
  end if;
 end process;
 ---------------------------------------------------------------------------------------------------
--!@brief synchronous process Detect_f_edge_rxd_filtered: detection of a falling edge on the 
+--!@brief Synchronous process Detect_f_edge_rxd_filtered: detection of a falling edge on the 
--! deglitched input signal(rxd_filtered). A buffer is used to store the last 2 bits of the signal.
+--! deglitched input signal (rxd_filtered).
 Detect_f_edge_rxd_filtered: process (uclk_i)
  begin
@@ -193,8 +201,10 @@ Detect_f_edge_rxd_filtered: process (uclk_i)
    end if;
  end process;
-  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --
-  -- Concurrent signals assignments
+ --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --
+-- Concurrent signal assignments
  rxd_filtered_f_edge_p_o   <= s_rxd_filtered_buff(1) and (not s_rxd_filtered_buff(0));
  rxd_filtered_o            <= s_rxd_filtered_d;
  sample_bit_p_o            <= sample_bit_p_i;

--- a/wf_rx_deserializer.vhd
+++ b/wf_rx_deserializer.vhd
@@ -53,6 +53,15 @@ use work.WF_PACKAGE.all;      --! definitions of types, constants, entities
 --!                  transition         :    ^
 --!                  sample_manch_bit_p : ^ ^ ^ ^ 
 --!                  sample_bit_p       : ^   ^   (this sampling will give the 0 and the 1)
+--!
+--!            ------------------------------------------------------------------------------------
+--!            Reminder:
+--!
+--!            Consumed RP_DAT frame structure :
+--!             _______ _______ ______  _______ ______ ______________ _______  ___________ _______
+--!            |__PRE__|__FSD__|_Ctrl_||__PDU__|_LGTH_|_..PureData.._|__MPS__||____FCS____|__FES__|
+--!
+--!            ------------------------------------------------------------------------------------
 --
 --
 --! @author    Pablo Alvarez Sanchez (Pablo.Alvarez.Sanchez@cern.ch)\n
@@ -67,17 +76,17 @@ use work.WF_PACKAGE.all;      --! definitions of types, constants, entities
 --
 --! @details \n 
 --
--!   \n<b>Dependencies:</b>  \n
+--!   \n<b>Dependencies:</b>         \n
--!     WF_reset_unit         \n
+--!            WF_reset_unit         \n
--!     WF_rx_tx_osc          \n
+--!            WF_rx_tx_osc          \n
--!     WF_rx_deglitcher      \n
+--!            WF_rx_deglitcher      \n
--!     WF_engine_control     \n
+--!            WF_engine_control     \n
--!     WF_inputs_synchronizer\n
+--!            WF_inputs_synchronizer\n
 -- 
 -- 
--!   \n<b>Modified by:</b>   \n
+--!   \n<b>Modified by:</b>          \n
--!     Pablo Alvarez Sanchez \n
+--!            Pablo Alvarez Sanchez \n
--!     Evangelia Gousiou     \n
+--!             Evangelia Gousiou    \n
 --
 --------------------------------------------------------------------------------------------------- 
 --
@@ -89,7 +98,7 @@ use work.WF_PACKAGE.all;      --! definitions of types, constants, entities
 --!                          units WF_rx_manch_code_check and Incoming_Bits_Index created;
 --!                          each manch bit of FES checked (bf was just each bit, so any D5 was FES) 
 --!                          code cleaned-up + commented.\n
--!     -> 12/2010 v0.03 EG  CRC_ok pulse transfered 16 bits later to match the FES;
+--!     -> 12/2010 v0.02 EG  CRC_ok pulse transfered 16 bits later to match the FES;
 --!                          like this we confirm that the CRC_ok_p arrived just before the FES,
 --!                          and any 2 bytes that could by chanche be seen as CRC, are neglected.  
 --!                          FSM data_field_byte state: redundant code removed:
@@ -104,7 +113,7 @@ use work.WF_PACKAGE.all;      --! definitions of types, constants, entities
 ---------------------------------------------------------------------------------------------------
 ---/!\----------------------------/!\----------------------------/!\-------------------------/!\---
--                               Sunplify Premier D-2009.12 Warnings                             --
+--                               Synplify Premier D-2009.12 Warnings                             --
 -- -- --  --  --  --  --  --  --  --  --  --  --  --  --  --  -- --  --  --  --  --  --  --  --  --
 --                                         No Warnings                                           --
 ---------------------------------------------------------------------------------------------------
@@ -177,10 +186,10 @@ architecture rtl of WF_rx_deserializer is
                    fsd_field, switch_to_deglitched, data_fcs_fes_fields);
  signal rx_st, nx_rx_st                                          : rx_st_t;
-  signal s_manch_code_viol_p, s_CRC_ok_p, s_CRC_ok_p_d16          : std_logic;
+  signal s_manch_code_viol_p, s_CRC_ok_p, s_CRC_ok_p_d16             : std_logic;
  signal s_fsd_last_bit, s_fes_wrong_bit, s_sample_manch_bit_p_d1 : std_logic;
  signal s_fes_detected_p, s_fes_detection_window                 : std_logic;
-  signal s_manch_not_ok, s_switching_to_deglitched                : std_logic;
+  signal s_manch_not_ok, s_switching_to_deglitched       : std_logic;
  signal s_receiving_fsd, s_receiving_bytes, s_receiving_pre      : std_logic;
  signal s_decr_manch_bit_index_p, s_manch_bit_index_load         : std_logic;
  signal s_manch_bit_index_is_zero, s_edge_outside_manch_window_p : std_logic;
@@ -424,13 +433,14 @@ architecture rtl of WF_rx_deserializer is
 ---------------------------------------------------------------------------------------------------
--                                          Bytes Creation                                       --
+--                                          Creating Bytes                                       --
 ---------------------------------------------------------------------------------------------------
 --!@brief Synchronous process Append_Bit_To_Byte: creation of bytes of data.
 --! A new bit of the (deglitched) input signal is appended to the output byte that is being formed
 --! when the Deserializer's FSM is in the "data_fcs_fes_fields" state, on the "sampling of a bit"
 --! moments.
  Append_Bit_To_Byte: process (uclk_i)
    begin
      if rising_edge (uclk_i) then
@@ -460,7 +470,8 @@ architecture rtl of WF_rx_deserializer is
 ---------------------------------------------------------------------------------------------------
 --!@brief Instantiation of a counter that manages the position of an incoming deglitched bit
--! inside a manch. encoded byte (16 bits).  
+--! inside a manch. encoded byte (16 bits).
  Incoming_Bits_Index: WF_decr_counter
  generic map(g_counter_lgth => 4)
  port map(
@@ -476,11 +487,13 @@ architecture rtl of WF_rx_deserializer is
 --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  -- 
  -- FSD aux signals concurrent assignments:
  s_fsd_bit        <= s_receiving_fsd   and FSD (to_integer(s_manch_bit_index));  
  s_fsd_last_bit   <= s_manch_bit_index_is_zero and sample_manch_bit_p_i;
  s_fsd_wrong_bit  <= (s_fsd_bit xor rxd_filtered_i) and sample_manch_bit_p_i; 
  -- FES aux signals concurrent assignments :
  s_fes_bit        <= s_receiving_bytes and FES (to_integer(s_manch_bit_index));
  s_fes_wrong_bit  <= (s_fes_bit xor rxd_filtered_i) and sample_manch_bit_p_i;   
  s_fes_detected_p <=s_fes_detection_window and sample_manch_bit_p_i and s_manch_bit_index_is_zero;     
@@ -488,6 +501,7 @@ architecture rtl of WF_rx_deserializer is
 --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  -- 
 --!@brief Combinatorial process that according to the state of the FSM sets values to the
 --! Incoming_Bits_Index inputs.
  Bit_Index: process (s_idle,s_receiving_pre, s_switching_to_deglitched, s_receiving_fsd,
                      s_receiving_bytes, s_manch_bit_index_is_zero,sample_manch_bit_p_i)
  begin
@@ -527,7 +541,8 @@ architecture rtl of WF_rx_deserializer is
 --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  -- 
 --!@brief Synchronous process FES_Detector: creation of a window that is activated at the 
--! beginning of an incoming byte and stays active as long as 16 incoming manch. bits match the FES. 
+--! beginning of an incoming byte and stays active as long as 16 incoming manch. bits match the FES.
  FES_Detector: process (uclk_i)
    begin
      if rising_edge (uclk_i) then
@@ -553,6 +568,7 @@ architecture rtl of WF_rx_deserializer is
 ---------------------------------------------------------------------------------------------------
 --!@brief Instantiation of the CRC calculator unit that verifies the received FCS field.
  CRC_Verification : WF_crc 
  generic map(c_GENERATOR_POLY_length => 16) 
  port map(
@@ -568,6 +584,7 @@ architecture rtl of WF_rx_deserializer is
 --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  -- 
 --!@brief Instantiation of the WF_rx_manch_code_check unit that checks for manch. code violations.
  Manch_Encoding_Verification: WF_rx_manch_code_check
  port map(
    uclk_i                => uclk_i,
@@ -583,6 +600,7 @@ architecture rtl of WF_rx_deserializer is
 --!@brief Synchronous process that manages the s_manch_code_viol_p signal: If at any point after
 --! the FSS and before the FES a code violation appears, the signal s_manch_not_ok stays
 --! asserted until the end of the corresponding frame.    
  Code_viol: process (uclk_i)
    begin
      if rising_edge (uclk_i) then
@@ -611,6 +629,7 @@ architecture rtl of WF_rx_deserializer is
 --! calculator unit is delayed for 16 manch. encoded bits. The matching of this delayed pulse with
 --! the FES pulse (s_fes_detected_p), would confirm that the two last bytes received before the
 --! FES were the correct CRC.
  CRC_OK_pulse_delay: process (uclk_i)
    begin
      if rising_edge (uclk_i) then
@@ -648,6 +667,7 @@ architecture rtl of WF_rx_deserializer is
 --                                   Concurrent signal assignments                               --
 ---------------------------------------------------------------------------------------------------
 -- aux signals concurrent assignments :
  s_manch_r_edge_p              <= signif_edge_window_i and rxd_r_edge_p_i;
  s_manch_f_edge_p              <= signif_edge_window_i and rxd_f_edge_p_i;
  s_bit_r_edge_p                <= adjac_bits_window_i and ( rxd_r_edge_p_i);
@@ -656,6 +676,7 @@ architecture rtl of WF_rx_deserializer is
 --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  -- 
  -- output signals concurrent assignments :
  byte_o                        <= s_byte; 
  rst_rx_osc_o                  <= s_idle;
  fss_received_p_o              <= s_receiving_fsd and s_fsd_last_bit;

--- a/wf_rx_tx_osc.vhd
+++ b/wf_rx_tx_osc.vhd
@@ -88,7 +88,7 @@ use work.WF_PACKAGE.all;     --! definitions of types, constants, entities
 ---------------------------------------------------------------------------------------------------
 ---/!\----------------------------/!\----------------------------/!\-------------------------/!\---
--                               Sunplify Premier D-2009.12 Warnings                             --
+--                               Synplify Premier D-2009.12 Warnings                             --
 -- -- --  --  --  --  --  --  --  --  --  --  --  --  --  --  -- --  --  --  --  --  --  --  --  --
 --                                         No Warnings                                           --
 ---------------------------------------------------------------------------------------------------
@@ -237,6 +237,7 @@ begin
    end if;
  end process;
 --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --  --
 -- Concurrent signal assignments concerning the receiver:
 -- creation of the windows where "significant edges" and "adjacent bits transitions" are expected
@@ -276,7 +277,6 @@ begin
  -- Edges between adjacent bits are expected inside the adjac_bits_window; if they do not arrive
  -- the rx_manch_clk and rx_bit_clk are inverted right after the end of the adjac_bits_window.
 rx_clk: process (uclk_i)
    begin
@@ -384,6 +384,7 @@ begin
    end if;
  end process;
 ---------------------------------------------------------------------------------------------------
 -- Concurrent signal assignments concerning the transmitter:
@@ -404,6 +405,10 @@ begin
                                              -- not s_tx_clk_d1       : ----|_____|-----|_____|---
                                              -- s_tx_clk_p            : __|-|___|-|___|-|___|-|___
+---------------------------------------------------------------------------------------------------
+--                                           Output signals                                      --
 ---------------------------------------------------------------------------------------------------
 -- Output signals construction:

--- a/wf_status_bytes_gen.vhd
+++ b/wf_status_bytes_gen.vhd
@@ -48,8 +48,8 @@ use work.WF_PACKAGE.all;      --! definitions of types, constants, entities
 --!            having been sent.            
 --
 --
--! @author    Pablo Alvarez Sanchez (Pablo.Alvarez.Sanchez@cern.ch)
+--! @author    Pablo Alvarez Sanchez (Pablo.Alvarez.Sanchez@cern.ch) \n
--!            Evangelia Gousiou     (Evangelia.Gousiou@cern.ch)
+--!            Evangelia Gousiou     (Evangelia.Gousiou@cern.ch)     \n
 --
 --
 --! @date 10/01/2011
@@ -61,10 +61,10 @@ use work.WF_PACKAGE.all;      --! definitions of types, constants, entities
 --! @details\n 
 --
 --!   \n<b>Dependencies:</b>\n
--!     data_if             \n
+--!     WF_consumption      \n
--!     tx_engine           \n
+--!     WF_bytes_retriever  \n
--!     WF_tx_rx            \n
+--!     WF_prod_permit      \n
--!     reset_logic         \n
+--!     WF_reset_unit       \n
 --
 --
 --!   \n<b>Modified by:</b>\n
@@ -88,7 +88,7 @@ use work.WF_PACKAGE.all;      --! definitions of types, constants, entities
 ---------------------------------------------------------------------------------------------------
 ---/!\----------------------------/!\----------------------------/!\-------------------------/!\---
--                               Sunplify Premier D-2009.12 Warnings                             --
+--                               Synplify Premier D-2009.12 Warnings                             --
 -- -- --  --  --  --  --  --  --  --  --  --  --  --  --  --  -- --  --  --  --  --  --  --  --  --
 -- "W CL189	Register bits s_nFIP_status_byte(0), s_nFIP_status_byte(1) are always 0, optimizing" --
 -- "W CL260	Pruning Register bits 0 and 1 of s_nFIP_status_byte(7 downto 0)"                     --
@@ -110,7 +110,7 @@ port (
    -- Signal from the WF_reset_unit
    nfip_urst_i             : in std_logic;  --! nanaoFIP internal reset
-    -- nanoFIP FIELDRIVE  
+    -- nanoFIP FIELDRIVE (synchronized with uclk)
    fd_txer_i               : in  std_logic; --! transmitter error
    fd_wdgn_i               : in  std_logic; --! watchdog on transmitter
@@ -206,16 +206,16 @@ begin
          --  --  --  --  --  --  --  -- --  --  --  --  --  --  --  --  --  --  --  --  --  --  --
-          -- t_txer
+          -- t_wder
          if (fd_wdgn_i = '0') then                              -- FIELDRIVE transmission error 
-            s_nFIP_status_byte(c_T_TXER_INDEX)  <= '1';
+            s_nFIP_status_byte(c_T_WDER_INDEX)  <= '1';
          end if;
          --  --  --  --  --  --  --  -- --  --  --  --  --  --  --  --  --  --  --  --  --  --  --
-          -- t_wder
+          -- t_rxer
          if (fd_txer_i = '1') then                              -- FIELDRIVE watchdog timer problem
-            s_nFIP_status_byte(c_T_WDER_INDEX)  <= '1';
+            s_nFIP_status_byte(c_T_TXER_INDEX)  <= '1';
          end if;
@@ -311,7 +311,7 @@ begin
        s_refreshment   <= '0';
      else
-        if rst_status_bytes_p_i = '1' then          -- the bit is reinitialized
+        if rst_status_bytes_p_i = '1' then          -- bit reinitialized after a var production
          s_refreshment <= '0';  
        elsif (var3_acc_i = '1') then               -- indication that the memory has been accessed