scm: fix diff revision param validation.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@4860 e93f8b46-1217-0410-a6f0-8f06a7374b81

scm: fix diff revision param validation.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@4860 e93f8b46-1217-0410-a6f0-8f06a7374b81
49fde372 · Toshi MARUYAMA · Eric Davis · 7934e32e · 49fde372 · 49fde372
Commit 49fde372 authored Feb 17, 2011 by Toshi MARUYAMA Committed by Eric Davis Apr 16, 2011
Showing with 7 additions and 1 deletion

repositories_controller.rb app/controllers/repositories_controller.rb +1 -1

repositories_subversion_controller_test.rb test/functional/repositories_subversion_controller_test.rb +6 -0

No files found.
--- a/app/controllers/repositories_controller.rb
+++ b/app/controllers/repositories_controller.rb
@@ -218,7 +218,7 @@ class RepositoriesController < ApplicationController
    @rev = params[:rev].blank? ? @repository.default_branch : params[:rev].strip
    @rev_to = params[:rev_to]
    
-    unless @rev.to_s.match(REV_PARAM_RE) && @rev.to_s.match(REV_PARAM_RE)
+    unless @rev.to_s.match(REV_PARAM_RE) && @rev_to.to_s.match(REV_PARAM_RE)
      if @repository.branches.blank?
        raise InvalidRevisionParam
      end

--- a/test/functional/repositories_subversion_controller_test.rb
+++ b/test/functional/repositories_subversion_controller_test.rb
@@ -172,6 +172,12 @@ class RepositoriesSubversionControllerTest < ActionController::TestCase
      assert_error_tag :content => /was not found/
    end

+    def test_invalid_revision_diff
+      get :diff, :id => 1, :rev => '1', :rev_to => 'something_weird'
+      assert_response 404
+      assert_error_tag :content => /was not found/
+    end
+
    def test_empty_revision
      ['', ' ', nil].each do |r|
        get :revision, :id => 1, :rev => r