Add etag check on the activity view to avoid rendering when not modified.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2982 e93f8b46-1217-0410-a6f0-8f06a7374b81

Add etag check on the activity view to avoid rendering when not modified.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2982 e93f8b46-1217-0410-a6f0-8f06a7374b81
a658679d · Jean-Philippe Lang · 06fff629 · a658679d · a658679d
Commit a658679d authored Oct 25, 2009 by Jean-Philippe Lang
Hide whitespace changes
Inline Side-by-side

Showing with 19 additions and 15 deletions

projects_controller.rb app/controllers/projects_controller.rb +16 -14

fetcher.rb lib/redmine/activity/fetcher.rb +3 -1

No files found.
--- a/app/controllers/projects_controller.rb
+++ b/app/controllers/projects_controller.rb
@@ -299,20 +299,22 @@ class ProjectsController < ApplicationController

    events = @activity.events(@date_from, @date_to)
    
-    respond_to do |format|
-      format.html { 
-        @events_by_day = events.group_by(&:event_date)
-        render :layout => false if request.xhr?
-      }
-      format.atom {
-        title = l(:label_activity)
-        if @author
-          title = @author.name
-        elsif @activity.scope.size == 1
-          title = l("label_#{@activity.scope.first.singularize}_plural")
-        end
-        render_feed(events, :title => "#{@project || Setting.app_title}: #{title}")
-      }
+    if events.empty? || stale?(:etag => [events.first, User.current])
+      respond_to do |format|
+        format.html { 
+          @events_by_day = events.group_by(&:event_date)
+          render :layout => false if request.xhr?
+        }
+        format.atom {
+          title = l(:label_activity)
+          if @author
+            title = @author.name
+          elsif @activity.scope.size == 1
+            title = l("label_#{@activity.scope.first.singularize}_plural")
+          end
+          render_feed(events, :title => "#{@project || Setting.app_title}: #{title}")
+        }
+      end
    end
    
  rescue ActiveRecord::RecordNotFound

--- a/lib/redmine/activity/fetcher.rb
+++ b/lib/redmine/activity/fetcher.rb
@@ -66,6 +66,7 @@ module Redmine
      end
      
      # Returns an array of events for the given date range
+      # sorted in reverse chronological order
      def events(from = nil, to = nil, options={})
        e = []
        @options[:limit] = options[:limit]
@@ -76,8 +77,9 @@ module Redmine
          end
        end
        
+        e.sort! {|a,b| b.event_datetime <=> a.event_datetime}
+        
        if options[:limit]
-          e.sort! {|a,b| b.event_date <=> a.event_date}
          e = e.slice(0, options[:limit])
        end
        e