Closed issue are not overdue, fixes r2140 (#2337).

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2361 e93f8b46-1217-0410-a6f0-8f06a7374b81

Closed issue are not overdue, fixes r2140 (#2337).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2361 e93f8b46-1217-0410-a6f0-8f06a7374b81
b11a1d85 · Jean-Philippe Lang · c9ca635f · b11a1d85 · b11a1d85
Commit b11a1d85 authored Feb 03, 2009 by Jean-Philippe Lang
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 1 deletion

issue.rb app/models/issue.rb +1 -1

issue_test.rb test/unit/issue_test.rb +1 -0

No files found.
--- a/app/models/issue.rb
+++ b/app/models/issue.rb
@@ -215,7 +215,7 @@ class Issue < ActiveRecord::Base
  # Returns true if the issue is overdue
  def overdue?
-    !due_date.nil? && (due_date < Date.today)
+    !due_date.nil? && (due_date < Date.today) && !status.is_closed?
  end
  # Users the issue can be assigned to

--- a/test/unit/issue_test.rb
+++ b/test/unit/issue_test.rb
@@ -226,5 +226,6 @@ class IssueTest < Test::Unit::TestCase
    assert !Issue.new(:due_date => Date.today).overdue?
    assert !Issue.new(:due_date => 1.day.from_now.to_date).overdue?
    assert !Issue.new(:due_date => nil).overdue?
+    assert !Issue.new(:due_date => 1.day.ago.to_date, :status => IssueStatus.find(:first, :conditions => {:is_closed => true})).overdue?
  end
 end