Fixed: Links get chopped by punctuation marks in anchors.

git-svn-id: http://redmine.rubyforge.org/svn/trunk@775 e93f8b46-1217-0410-a6f0-8f06a7374b81

Fixed: Links get chopped by punctuation marks in anchors.
git-svn-id: http://redmine.rubyforge.org/svn/trunk@775 e93f8b46-1217-0410-a6f0-8f06a7374b81
b4d66593 · Jean-Philippe Lang · cae547a7 · b4d66593 · b4d66593
Commit b4d66593 authored Sep 30, 2007 by Jean-Philippe Lang
Hide whitespace changes
Inline Side-by-side

Showing with 12 additions and 14 deletions

wiki_formatting.rb lib/redmine/wiki_formatting.rb +10 -14

application_helper_test.rb test/unit/helpers/application_helper_test.rb +2 -0

No files found.
--- a/lib/redmine/wiki_formatting.rb
+++ b/lib/redmine/wiki_formatting.rb
 require 'redcloth'
 require 'coderay'
-
+require 'pp'
 module Redmine
  module WikiFormatting
  
@@ -79,29 +79,25 @@ module Redmine
                        (
                          (?:https?://)|           # protocol spec, or
                          (?:www\.)                # www.*
-                        ) 
+                        )
                        (
-                          [-\w]+                   # subdomain or domain
-                          (?:\.[-\w]+)*            # remaining subdomains or domain
-                          (?::\d+)?                # port
-                          (?:/(?:(?:[~\w\+%-]|(?:[,.;:][^\s$]))+)?)* # path
-                          (?:\?[\w\+%&=.;-]+)?     # query string
-                          (?:\#[\w\-]*)?           # trailing anchor
+                          (\S+?)                   # url
+                          (\/)?                    # slash
                        )
-                        ([[:punct:]]|\s|<|$)       # trailing text
+                        ([^\w\=\/;]*?)               # post
+                        (?=<|\s|$)
                       }x unless const_defined?(:AUTO_LINK_RE)

      # Turns all urls into clickable links (code from Rails).
      def inline_auto_link(text)
        text.gsub!(AUTO_LINK_RE) do
-          all, a, b, c, d = $&, $1, $2, $3, $4
-          if a =~ /<a\s/i || a =~ /![<>=]?/
+          all, leading, proto, url, post = $&, $1, $2, $3, $6
+          if leading =~ /<a\s/i || leading =~ /![<>=]?/
            # don't replace URL's that are already linked
            # and URL's prefixed with ! !> !< != (textile images)
            all
-          else
-            text = b + c
-            %(#{a}<a href="#{b=="www."?"http://www.":b}#{c}">#{text}</a>#{d})
+          else            
+            %(#{leading}<a href="#{proto=="www."?"http://www.":proto}#{url}">#{proto + url}</a>#{post})
          end
        end
      end

--- a/test/unit/helpers/application_helper_test.rb
+++ b/test/unit/helpers/application_helper_test.rb
@@ -29,6 +29,8 @@ class ApplicationHelperTest < HelperTestCase
  def test_auto_links
    to_test = {
      'http://foo.bar' => '<a href="http://foo.bar">http://foo.bar</a>',
+      'http://foo.bar.' => '<a href="http://foo.bar">http://foo.bar</a>.',
+      'http://foo.bar/foo.bar#foo.bar.' => '<a href="http://foo.bar/foo.bar#foo.bar">http://foo.bar/foo.bar#foo.bar</a>.',
      'www.foo.bar' => '<a href="http://www.foo.bar">www.foo.bar</a>',
      'http://foo.bar/page?p=1&t=z&s=' => '<a href="http://foo.bar/page?p=1&#38;t=z&#38;s=">http://foo.bar/page?p=1&#38;t=z&#38;s=</a>',
      'http://foo.bar/page#125' => '<a href="http://foo.bar/page#125">http://foo.bar/page#125</a>'