Fixed: custom field selection is not saved when unchecking them all on project settings

git-svn-id: http://redmine.rubyforge.org/svn/trunk@1083 e93f8b46-1217-0410-a6f0-8f06a7374b81

Fixed: custom field selection is not saved when unchecking them all on project settings
git-svn-id: http://redmine.rubyforge.org/svn/trunk@1083 e93f8b46-1217-0410-a6f0-8f06a7374b81
d79c20c4 · Jean-Philippe Lang · 889bf388 · d79c20c4 · d79c20c4 · d79c20c4
Commit d79c20c4 authored Jan 20, 2008 by Jean-Philippe Lang
Showing with 4 additions and 3 deletions

projects_controller.rb app/controllers/projects_controller.rb +0 -1

_form.rhtml app/views/projects/_form.rhtml +2 -1

projects_controller_test.rb test/functional/projects_controller_test.rb +2 -1

No files found.
--- a/app/controllers/projects_controller.rb
+++ b/app/controllers/projects_controller.rb
@@ -113,7 +113,6 @@ class ProjectsController < ApplicationController
  # Edit @project
  def edit
    if request.post?
-      @project.custom_fields = IssueCustomField.find(params[:custom_field_ids]) if params[:custom_field_ids]
      if params[:custom_fields]
        @custom_values = ProjectCustomField.find(:all, :order => "#{CustomField.table_name}.position").collect { |x| CustomValue.new(:custom_field => x, :customized => @project, :value => params["custom_fields"][x.id.to_s]) }
        @project.custom_values = @custom_values

--- a/app/views/projects/_form.rhtml
+++ b/app/views/projects/_form.rhtml
@@ -35,10 +35,11 @@
 <fieldset class="box"><legend><%=l(:label_custom_field_plural)%></legend>
 <% for custom_field in @custom_fields %>
    <label class="floating">
-	<%= check_box_tag "custom_field_ids[]", custom_field.id, ((@project.custom_fields.include? custom_field) or custom_field.is_for_all?), (custom_field.is_for_all? ? {:disabled => "disabled"} : {}) %>
+	<%= check_box_tag 'project[custom_field_ids][]', custom_field.id, ((@project.custom_fields.include? custom_field) or custom_field.is_for_all?), (custom_field.is_for_all? ? {:disabled => "disabled"} : {}) %>
 	<%= custom_field.name %>
 	</label>
 <% end %>
+<%= hidden_field_tag 'project[custom_field_ids][]', '' %>
 </fieldset>
 <% end %>
 <!--[eoform:project]-->

--- a/test/functional/projects_controller_test.rb
+++ b/test/functional/projects_controller_test.rb
@@ -71,7 +71,8 @@ class ProjectsControllerTest < Test::Unit::TestCase
  
  def test_edit
    @request.session[:user_id] = 2 # manager
-    post :edit, :id => 1, :project => {:name => 'Test changed name'}
+    post :edit, :id => 1, :project => {:name => 'Test changed name',
+                                       :custom_field_ids => ['']}
    assert_redirected_to 'projects/settings/ecookbook'
    project = Project.find(1)
    assert_equal 'Test changed name', project.name