Skip to content

O
OHR Support
Commit daa4272c authored by Eric Davis's avatar Eric Davis
Browse files
Options

Refactor: extract method in bulk_update. 

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@4040 e93f8b46-1217-0410-a6f0-8f06a7374b81
parent bc951a9d
Hide whitespace changes
Inline Side-by-side
Showing with 8 additions and 4 deletions
app/controllers/issues_controller.rb
View file @ daa4272c
......@@ -198,11 +198,8 @@ class IssuesController < ApplicationController
def bulk_update
@issues.sort!
attributes = parse_params_for_bulk_issue_attributes(params)
attributes = (params[:issue] || {}).reject {|k,v| v.blank?}
attributes.keys.each {|k| attributes[k] = '' if attributes[k] == 'none'}
attributes[:custom_field_values].reject! {|k,v| v.blank?} if attributes[:custom_field_values]
unsaved_issue_ids = []
@issues.each do |issue|
issue.reload
......@@ -318,4 +315,11 @@ private
return false
end
end
def parse_params_for_bulk_issue_attributes(params)
attributes = (params[:issue] || {}).reject {|k,v| v.blank?}
attributes.keys.each {|k| attributes[k] = '' if attributes[k] == 'none'}
attributes[:custom_field_values].reject! {|k,v| v.blank?} if attributes[:custom_field_values]
attributes
end
end
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment