diag/diag-yes.c: use pp_vprintf

Now that we have vprintf, we can save a buffer in the stack and simplify pp_diag_printf and pp_timed_printf. Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

diag/diag-yes.c: use pp_vprintf
Now that we have vprintf, we can save a buffer in the stack and simplify pp_diag_printf and pp_timed_printf. Signed-off-by: Alessandro Rubini <rubini@gnudd.com>
b00ce939 · Alessandro Rubini · b7818cba · b00ce939
Commit b00ce939 authored Feb 25, 2013 by Alessandro Rubini
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 7 deletions

diag-yes.c diag/diag-yes.c +6 -7

No files found.
--- a/diag/diag-yes.c
+++ b/diag/diag-yes.c
@@ -46,23 +46,22 @@ void pp_diag_fatal(struct pp_instance *ppi, char *s1, char *s2)
 void pp_diag_printf(struct pp_instance *ppi, char *fmt, ...)
 {
 	va_list args;
-	char buf[128];

+	pp_printf("MESSAGE for %p: ", ppi);
 	va_start(args, fmt);
-	pp_vsprintf(buf, fmt, args);
+	pp_vprintf(fmt, args);
 	va_end(args);
-	pp_printf("MESSAGE for %p: %s", ppi, buf);
 }

 void pp_timed_printf(char *fmt, ...)
 {
 	va_list args;
-	char buf[128];
 	TimeInternal t;
+
 	pp_get_tstamp(&t);
+	pp_printf("%09d.%03d ", (int)t.seconds,
+		  (int)t.nanoseconds / 1000000);
 	va_start(args, fmt);
-	pp_vsprintf(buf, fmt, args);
+	pp_vprintf(fmt, args);
 	va_end(args);
-	pp_printf("%09d.%03d %s", (int)t.seconds,
-		  (int)t.nanoseconds / 1000000, buf);
 }