If debug level for "frames" is 2 or more, net_ops->send and
net_ops->recv now dump the data to stdout. The format is the same
of tools/ptpdump, with "send:" and "recv:" in front. This is an example:

  send: TIME: (1363277414 - 0x5141f666) 17:10:14.748281
  send: VERSION: 2 (type 11, len 64, domain 0)
  send: FLAGS: 0x0002 (correction 0x00000000)
  send: PORT: 00-22-15-ff-fe-d7-c0-ef-00-01
  send: REST: seq 9, ctrl 5, log-interval 1
  send: MESSAGE: (G) ANNOUNCE
  send: MSG-ANNOUNCE: stamp 0.000000000
  send: MSG-ANNOUNCE: grandmaster-quality f8-fe-60f0
  send: MSG-ANNOUNCE: grandmaster-prio 248 248
  send: MSG-ANNOUNCE: grandmaster-id 00-22-15-ff-fe-d7-c0-ef
  send: DUMP: payload (size 64)
  send: DUMP: 8b 02 00 40  00 00 02 00  00 00 00 00  00 00 00 00
  send: DUMP: 00 00 00 00  00 22 15 ff  fe d7 c0 ef  00 01 00 09
  send: DUMP: 05 01 00 00  00 00 00 00  00 00 00 00  00 00 11 f8
  send: DUMP: f8 fe f0 60  f8 00 22 15  ff fe d7 c0  ef 00 00 a0
  diag-frames-1-eth0: SENT 64 bytes at 1363277414.748281517 (announce)

And this is the same frame in the other host:

  recv: TIME: (1363277414 - 0x5141f666) 17:10:14.691032
  recv: VERSION: 2 (type 11, len 64, domain 0)
  recv: FLAGS: 0x0002 (correction 0x00000000)
  recv: PORT: 00-22-15-ff-fe-d7-c0-ef-00-01
  recv: REST: seq 9, ctrl 5, log-interval 1
  recv: MESSAGE: (G) ANNOUNCE
  recv: MSG-ANNOUNCE: stamp 0.000000000
  recv: MSG-ANNOUNCE: grandmaster-quality f8-fe-60f0
  recv: MSG-ANNOUNCE: grandmaster-prio 248 248
  recv: MSG-ANNOUNCE: grandmaster-id 00-22-15-ff-fe-d7-c0-ef
  recv: DUMP: payload (size 64)
  recv: DUMP: 8b 02 00 40  00 00 02 00  00 00 00 00  00 00 00 00
  recv: DUMP: 00 00 00 00  00 22 15 ff  fe d7 c0 ef  00 01 00 09
  recv: DUMP: 05 01 00 00  00 00 00 00  00 00 00 00  00 00 11 f8
  recv: DUMP: f8 fe f0 60  f8 00 22 15  ff fe d7 c0  ef 00 00 a0
  diag-frames-1-eth0: RECV 64 bytes at 1363277414.691032726 (type b)

This is what I got for the same frame in a ptpdump running in the
master.

  TIME: (1363277414 - 0x5141f666) 17:10:14.748376
  ETH: 0800 (00:22:15:d7:c0:ef -> 01:00:5e:00:01:81)
  IP: 17 (192.168.16.1 -> 224.0.1.129) len 92
  UDP: (320 -> 320) len 72
  VERSION: 2 (type 11, len 64, domain 0)
  FLAGS: 0x0002 (correction 0x00000000)
  PORT: 00-22-15-ff-fe-d7-c0-ef-00-01
  REST: seq 9, ctrl 5, log-interval 1
  MESSAGE: (G) ANNOUNCE
  MSG-ANNOUNCE: stamp 0.000000000
  MSG-ANNOUNCE: grandmaster-quality f8-fe-60f0
  MSG-ANNOUNCE: grandmaster-prio 248 248
  MSG-ANNOUNCE: grandmaster-id 00-22-15-ff-fe-d7-c0-ef
  DUMP: payload (size 64)
  DUMP: 8b 02 00 40  00 00 02 00  00 00 00 00  00 00 00 00
  DUMP: 00 00 00 00  00 22 15 ff  fe d7 c0 ef  00 01 00 09
  DUMP: 05 01 00 00  00 00 00 00  00 00 00 00  00 00 11 f8
  DUMP: f8 fe f0 60  f8 00 22 15  ff fe d7 c0  ef 00 00 a0
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

This is oh so boring, but I need to differentiate send from receive
when dumping from withing ppsi itself.  This is a long patch that has
no effect on tools/ptpdump, since it pases the empty string as prefix.
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

This moves some stuff between dump-main.c and dump-funcs.c, preparing
for dump-funcs to be used within ppsi itself.
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

pp_diag_allow(ppi, thing, level) can be used as a conditional
to mask off diagnostic prints that cannot be individually
written as pp_diag()  (this mainly applies to frame dumping, introduced
in later commits).
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Since dump-funcs.c is going to be used within ppsi itself, print the
empty separating lines, as well as the time difference from the
previous frame in main, not in dumping functions.

This has no effect on ptpdump itself, it's only a preparation for reuse
of the code.
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

When building freestanding we need to save space. Avoid printing pdelay
messages that are neither sent nor used if received.
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

I'm adding generic dump code to the receive and send code paths,
so I need the length of the incoming frame when first "unpacking" it,
to dump the whole frame using code from tools/dump-funcs.c
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

This commit allows dump-funcs.c to be build from a freestanding
environment. It uses __STDC_HOSTED__ to select what to include,
and relies on "network_types.h" to fill the gaps. Such header is not
part of this commit.
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Include <ppsi/ieee1588_types.h> in tools/, like the rest of the code
does.
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

This commit removes the "dest" argument to dumpstruct(), which now
uses printf() and not fprintf(dest,).  I plan to use these functions
withing PPSi itself if the "frames" diagnostic level is 2, and I'd
better avoid to hack around fprintf.

ptpdump is not changed, as it already used dumpstruct() with stdout
as destination.
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

I don't want to declare globals in header files by error (see previous
commit).  So I'd better use this flag to request "multiple definition"
errors at build time.
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

In commit 7c14152c I removed some typedef, in my quest for getting rid
of them.  But I forgot to remove the type name, so we got "TLV" and
similar global variables in the object files.  This fixes the buglet,
then I add -fno-common to prevent this for happening againg.
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Commit f9f487ff made ClockIdentity into a structure, but
I didn't rebuild the tools, which are affected by the type
definitions.  This fixes the building of ptpdump.
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

This simplifies the dataset_cmp a little more, and adds some comment.
Nothing changes in the outcome of this commit but I'm unsure about the
code (i.e about the original code).

The specification says to compare *port* identities, but we are
comparing clock identities instead. This is the same in the original
ptpd, so if it is wrong it has always been.

We'll be able to see what happens when checking with several masters,
after porting ppsi to multi-link setup.
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

This replaces
     memcmp(a, b, PP_CLOCK_IDENTITY_LENGTH)
with
     idcmp(a, b)
and makes no other changes.
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

We should use time operations instead. I forgot the protorype
in the header, and now we fail the link step of wrpc-sw with ppsi.

Bug introduced in 4b07d444, 106 commits ago.
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

We don't have st_com_restart_annrec_timer any more, but
I forgot to remove its prototype from the headers. This lead
to a link failure in wrpc-sw with the ppsi submodule.

But introduced in 415e530e, 96 commits ago.
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

the field is used in wrpc-sw, so move it out of "#if 0".
Bug introduced by e441b48b, 134 commits ago.
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

The code, when receiving announce, was setting a flag in order to run
bmc at the next iteration, when that happened, the frame just received
was discarded in favour for the programmed state update.

This commits remove some fields and one helper function, so the new
announce is immediately processed and no frame is lost.
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

the portState field is probably a relic of ptpd, then the state
machine was a single switch() statement.  Many places were still
setting it, but nobody was ever reading the field.
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

There is no need for a "msg_tmp" in the pp-instance. All uses are
really temporary to a function, so we can use local variables instead.

(This is not the same as what was called tmp_header, which was
referenced all over message processing, so it still exists, though
renamed).
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

A large number of functions here got hdr and ann, but struct
pp_frgn_master includes such fields, and most callers passed hdr and
ann from the same structure.

So I chose to pass a foreign master instead of the two components, but
I'm still unable to remove the two full structures inside until I
clean up the msg.c mess.   So, at the end, this is not really a step
forward, but it helps such later step.
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Since WR only needs one byte of information in the announce structure,
we can make is generic by calling it differently.

This changes only the name (and the size: it is now unsigned long),
but has no effect on the marshalling/unmarshalling of such data.

I'm touching this because I'm working on announce messages (as related
to foreign masters).
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

I renamed port_identity to port_id so the compiler helped me.
Then, since both fields are used at the same time, compare/copy
them in a single shot.
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

The field was only to be set and reported, not really used.  We
definitely need a way to age potential masters, but counting announce
messages without expiration is not the way.
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>

Trivially, return what we have, becuase less than zero is less than
zero.  No, the wouldn't pass my exam.
Signed-off-by: Alessandro Rubini <rubini@gnudd.com>