bugfix: bad vme_addr validation

The new vme_addr sysfs attribute had incorrect validation: it was the old value stored in the card structure who was validated by mistake. Moreover, the vme_addr is an offset, so it has to be compared with the configured size, not the end of the (absolute) vme address range of the board.

bugfix: bad vme_addr validation
The new vme_addr sysfs attribute had incorrect validation: it was the old value stored in the card structure who was validated by mistake. Moreover, the vme_addr is an offset, so it has to be compared with the configured size, not the end of the (absolute) vme address range of the board.
bec5f8e4 · Juan David González Cobas · 51351e3d · bec5f8e4
Commit bec5f8e4 authored Jan 17, 2014 by Juan David González Cobas
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 3 deletions

svec-sysfs.c kernel/svec-sysfs.c +2 -3

No files found.
--- a/kernel/svec-sysfs.c
+++ b/kernel/svec-sysfs.c
@@ -205,11 +205,10 @@ ATTR_STORE_CALLBACK(vme_addr)
 	if (sscanf(buf, "%i", &addr) != 1)
 		return -EINVAL;

-	if (card->vme_raw_addr >=
-	    card->cfg_cur.vme_base + card->cfg_cur.vme_size)
+	if (addr >= card->cfg_cur.vme_size)
 		return -EINVAL;

-	if (card->vme_raw_addr & 3)
+	if (addr & 3)
 		return -EINVAL;

 	card->vme_raw_addr = addr;