[HAL] bugfix: prevent reseting TIMING_MODE if non-slave port is unplugged

If there were more ports connected than just slave port, unplugging any of the ports would result (on BC) the timing_mode to be changed to FREE_MASTER. As a consquence, the port in slave state was reseted and would re-establishs sync. It was fixed by checking whether the unplugged port was slave (i.e. was locked)

[HAL] bugfix: prevent reseting TIMING_MODE if non-slave port is unplugged
If there were more ports connected than just slave port, unplugging any of the ports would result (on BC) the timing_mode to be changed to FREE_MASTER. As a consquence, the port in slave state was reseted and would re-establishs sync. It was fixed by checking whether the unplugged port was slave (i.e. was locked)
563d1b7e · Maciej Lipinski · Jean-Claude BAU · 92acd8b1 · 563d1b7e
Commit 563d1b7e authored Sep 06, 2019 by Maciej Lipinski Committed by Jean-Claude BAU Oct 11, 2019
Hide whitespace changes
Inline Side-by-side

Showing with 8 additions and 1 deletion

hal_port_fsm.c userspace/wrsw_hal/hal_port_fsm.c +8 -1

No files found.
--- a/userspace/wrsw_hal/hal_port_fsm.c
+++ b/userspace/wrsw_hal/hal_port_fsm.c
@@ -396,7 +396,14 @@ static void _init_port(struct hal_port_state * ps)
 static void _unlock_port( struct hal_port_state * ps)
 {

-	if ( hal_tmg_get_mode()==HAL_TIMING_MODE_BC ) {
+	/* reset timing mode to FREE (running) MASTER only if
+	   we are on Boundary Clock and the disconnected port
+	   has been locked (i.e. it was a SLAVE). In all other
+	   cases to nothing (e.g. if we did not chekc the locked
+	   flag, we would be unlocking Boundary Clock in the case
+	   of unplugging link from port in Master/Passive state) */
+	if ( hal_tmg_get_mode()==HAL_TIMING_MODE_BC &&
+	     ps->locked == 1) {
 		hal_tmg_set_mode(HAL_TIMING_MODE_FREE_MASTER);
 	}